issue_comments

Table actions

3 rows where issue = 267521588 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • Make passing a DataArray for the xarray.concat dim argument equivalent to passing a pandas Index · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
356661287 https://github.com/pydata/xarray/issues/1646#issuecomment-356661287 https://api.github.com/repos/pydata/xarray/issues/1646 MDEyOklzc3VlQ29tbWVudDM1NjY2MTI4Nw== shoyer 1217238 2018-01-10T16:44:00Z 2018-01-10T16:44:00Z MEMBER

What is the desired behaviour in this case viz. do we preserve dimension name new_dim or assign new name stat?

Oh, this is trickier than I thought!

The challenge is that once you make the DataArray, there is no good way to know if a default dimension name like 'dim_0' was intentional or not.

The way to handle this currently is to pass a 1-dimensional xarray.Variable object for the dim argument. These don't have separate names, so there's no ambiguity: In [5]: xarray.concat([xarray.DataArray(1), xarray.DataArray(2)], dim=xarray.Variable('x', [3, 4])) Out[5]: <xarray.DataArray (x: 2)> array([1, 2]) Coordinates: * x (x) int64 3 4

But this is a little verbose. Potentially we could call xarray.as_variable() on tuple inputs (like in the Dataset constructor) so dim=('x', [3, 4]) works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make passing a DataArray for the xarray.concat dim argument equivalent to passing a pandas Index 267521588
338576932 https://github.com/pydata/xarray/issues/1646#issuecomment-338576932 https://api.github.com/repos/pydata/xarray/issues/1646 MDEyOklzc3VlQ29tbWVudDMzODU3NjkzMg== shoyer 1217238 2017-10-23T07:55:59Z 2017-10-23T07:55:59Z MEMBER

This is the location of the helper function that parsing the dim argument: https://github.com/pydata/xarray/blob/9763a66e0e4675e7adc3fff3830c62f0e31a2bb3/xarray/core/combine.py#L123

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make passing a DataArray for the xarray.concat dim argument equivalent to passing a pandas Index 267521588
338576290 https://github.com/pydata/xarray/issues/1646#issuecomment-338576290 https://api.github.com/repos/pydata/xarray/issues/1646 MDEyOklzc3VlQ29tbWVudDMzODU3NjI5MA== shoyer 1217238 2017-10-23T07:53:22Z 2017-10-23T07:53:22Z MEMBER

Agreed, this should definitely work! (I think the fact that it doesn't is probably related to the relatively recent change that made coordinate labels along dimensions optional.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make passing a DataArray for the xarray.concat dim argument equivalent to passing a pandas Index 267521588

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);