issue_comments

Table actions

8 rows where issue = 267028954 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • WIP: Feature/interpolate · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
354530255 https://github.com/pydata/xarray/pull/1640#issuecomment-354530255 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM1NDUzMDI1NQ== fujiisoup 6815844 2017-12-30T06:22:21Z 2017-12-30T06:22:21Z MEMBER

Thanks for this great work!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954
354530135 https://github.com/pydata/xarray/pull/1640#issuecomment-354530135 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM1NDUzMDEzNQ== fujiisoup 6815844 2017-12-30T06:19:15Z 2017-12-30T06:19:15Z MEMBER

ready to go?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954
353415140 https://github.com/pydata/xarray/pull/1640#issuecomment-353415140 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM1MzQxNTE0MA== max-sixty 5635139 2017-12-21T17:53:43Z 2017-12-21T17:53:43Z MEMBER

This is great! While I left some comments, I don't think any warrant changes now, as long as ppl are good with the interpolate_na name

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954
353284666 https://github.com/pydata/xarray/pull/1640#issuecomment-353284666 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM1MzI4NDY2Ng== fujiisoup 6815844 2017-12-21T08:05:10Z 2017-12-21T08:05:10Z MEMBER

This looks good to me. Thanks for the great work :)

I will merge it in this weekend if there are no further comments.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954
352494126 https://github.com/pydata/xarray/pull/1640#issuecomment-352494126 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM1MjQ5NDEyNg== jhamman 2443309 2017-12-18T17:19:59Z 2017-12-18T17:19:59Z MEMBER

@fujiisoup - care to take another pass here? I think this is done but would appreciate a few more reviews. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954
344108532 https://github.com/pydata/xarray/pull/1640#issuecomment-344108532 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM0NDEwODUzMg== jhamman 2443309 2017-11-14T00:48:24Z 2017-11-14T00:48:24Z MEMBER

This is ready for some more reviews. I'm seeing some failing tests on the py27-min build that I'm struggling to detangle at the moment but I'm pretty sure they're just pytest related.

cc @darothen - I'd particularly appreciate your thoughts on the interpolators.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954
341926678 https://github.com/pydata/xarray/pull/1640#issuecomment-341926678 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM0MTkyNjY3OA== jhamman 2443309 2017-11-04T20:15:41Z 2017-11-04T20:15:41Z MEMBER

@dcherian - Yes, we can do that. Just haven't gotten there yet.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954
341926310 https://github.com/pydata/xarray/pull/1640#issuecomment-341926310 https://api.github.com/repos/pydata/xarray/issues/1640 MDEyOklzc3VlQ29tbWVudDM0MTkyNjMxMA== dcherian 2448579 2017-11-04T20:10:47Z 2017-11-04T20:10:47Z MEMBER

@jhamman Would it be possible to have a limit option like pandas?

Quoting http://pandas.pydata.org/pandas-docs/stable/generated/pandas.Series.interpolate.html ``` limit : int, default None.

Maximum number of consecutive NaNs to fill. Must be greater than 0.

```

I suspect that a lot of the time, users want to fill in "small" gaps but not "large" ones. It is what I usually do.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Feature/interpolate 267028954

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);