issue_comments

Table actions

4 rows where issue = 264764526 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Add _ipython_key_completions_ to xarray.Dataset · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
336500105 https://github.com/pydata/xarray/issues/1628#issuecomment-336500105 https://api.github.com/repos/pydata/xarray/issues/1628 MDEyOklzc3VlQ29tbWVudDMzNjUwMDEwNQ== fujiisoup 6815844 2017-10-13T16:21:26Z 2017-10-13T16:21:26Z MEMBER

That's correct. Attribute-style access was always intended as fall-back for convenience purposes, but getitem (for programmatic access) is intentionally stricter.

OK. Sent a PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add _ipython_key_completions_ to xarray.Dataset 264764526
336488363 https://github.com/pydata/xarray/issues/1628#issuecomment-336488363 https://api.github.com/repos/pydata/xarray/issues/1628 MDEyOklzc3VlQ29tbWVudDMzNjQ4ODM2Mw== shoyer 1217238 2017-10-13T15:37:21Z 2017-10-13T15:37:21Z MEMBER

This type of data access is convenient but sometimes conflicts to the original attributes, e.g. T cannot be accessed like this.

The Dataset T property for transpose should be deprecated -- but that's a separate matter: https://github.com/pydata/xarray/issues/1232

Can we gradually deprecate this after implementing ipython_key_completions()?

I am hesitant to deprecate this since it is so widely used. But you're right that this serves the main use cases.

An attribute foo can be accessed only by attribute-style, but not __getitem__ style, da[foo].

That's correct. Attribute-style access was always intended as fall-back for convenience purposes, but __getitem__ (for programmatic access) is intentionally stricter.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add _ipython_key_completions_ to xarray.Dataset 264764526
336485515 https://github.com/pydata/xarray/issues/1628#issuecomment-336485515 https://api.github.com/repos/pydata/xarray/issues/1628 MDEyOklzc3VlQ29tbWVudDMzNjQ4NTUxNQ== fujiisoup 6815844 2017-10-13T15:27:04Z 2017-10-13T15:27:04Z MEMBER

I am trying to implement this inside AttrAccessMixin class. I am wondering if the following is a designed behavior.

```python In [1]: import xarray as xr ...: da = xr.DataArray([0, 1, 2], dims=['x'], attrs={'foo': 'brabra'}) ...: da ...: Out[1]: <xarray.DataArray (x: 3)> array([0, 1, 2]) Dimensions without coordinates: x Attributes: foo: brabra

In [2]: da.foo Out[2]: 'brabra' ```

An attribute foo can be accessed only by attribute-style, but not __getitem__ style, da[foo].

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add _ipython_key_completions_ to xarray.Dataset 264764526
336020796 https://github.com/pydata/xarray/issues/1628#issuecomment-336020796 https://api.github.com/repos/pydata/xarray/issues/1628 MDEyOklzc3VlQ29tbWVudDMzNjAyMDc5Ng== fujiisoup 6815844 2017-10-12T04:57:33Z 2017-10-12T04:57:33Z MEMBER

Oh. It is what I have been looking for!

xarray's attribute-like data access, e.g. ds.temperature, was introduced for the purpose? This type of data access is convenient but sometimes conflicts to the original attributes, e.g. T cannot be accessed like this.

Can we gradually deprecate this after implementing _ipython_key_completions_()?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add _ipython_key_completions_ to xarray.Dataset 264764526

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);