home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

5 rows where issue = 264209937 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

  • fmaussion 3
  • shoyer 2

issue 1

  • repr of class methods · 5 ✖

author_association 1

  • MEMBER 5
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
336067289 https://github.com/pydata/xarray/issues/1620#issuecomment-336067289 https://api.github.com/repos/pydata/xarray/issues/1620 MDEyOklzc3VlQ29tbWVudDMzNjA2NzI4OQ== fmaussion 10050469 2017-10-12T09:02:55Z 2017-10-12T09:02:55Z MEMBER

Closing this, as there are other more important things to deal with.

the major issue here is that the important information (bound method ImplementsArrayReduce._reduce_method.<locals>.wrapped_func of) is overwhelmed by what looks like a variable. But students should learn how to read carefully anyway ;-)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  repr of class methods 264209937
335895802 https://github.com/pydata/xarray/issues/1620#issuecomment-335895802 https://api.github.com/repos/pydata/xarray/issues/1620 MDEyOklzc3VlQ29tbWVudDMzNTg5NTgwMg== shoyer 1217238 2017-10-11T17:58:23Z 2017-10-11T17:58:23Z MEMBER

My guess is that NumPy's method repr is somehow due to the fact that np.ndarray is implemented in C.

There might be some speed implication here to writing a wrapper (since it requires adding another layer of indirection) but I doubt that makes much of a difference for xarray users.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  repr of class methods 264209937
335707038 https://github.com/pydata/xarray/issues/1620#issuecomment-335707038 https://api.github.com/repos/pydata/xarray/issues/1620 MDEyOklzc3VlQ29tbWVudDMzNTcwNzAzOA== fmaussion 10050469 2017-10-11T07:12:49Z 2017-10-11T07:12:49Z MEMBER

I guess that consistency is important too. Numpy is a bit less verbose though:

python In [3]: a = np.linspace(1, 2) In [4]: a.min Out[4]: <function ndarray.min> Maybe a compromise would be more beginner friendly (e.g. <bound method ImplementsArrayReduce._reduce_method.<locals>.wrapped_func of <xarray.DataArray 'toa_sw_all_mon' (month: 12, lat: 180, lon: 360)>>) but at the same time I'm not sure it's worth the trouble...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  repr of class methods 264209937
335576001 https://github.com/pydata/xarray/issues/1620#issuecomment-335576001 https://api.github.com/repos/pydata/xarray/issues/1620 MDEyOklzc3VlQ29tbWVudDMzNTU3NjAwMQ== shoyer 1217238 2017-10-10T19:06:30Z 2017-10-11T01:43:24Z MEMBER

I think we could probably change this by adding a custom wrapping using descriptors, but I'm not sure that's actually a good idea. This is the standard Python repr for methods, e.g., consider: ```

df = pd.DataFrame({'x': range(1000)}) df.min <bound method DataFrame.min of x 0 0 1 1 2 2 3 3 4 4 5 5 6 6 7 7 8 8 9 9 10 10 11 11 12 12 13 13 14 14 15 15 16 16 17 17 18 18 19 19 20 20 21 21 22 22 23 23 24 24 25 25 26 26 27 27 28 28 29 29 .. ... 970 970 971 971 972 972 973 973 974 974 975 975 976 976 977 977 978 978 979 979 980 980 981 981 982 982 983 983 984 984 985 985 986 986 987 987 988 988 989 989 990 990 991 991 992 992 993 993 994 994 995 995 996 996 997 997 998 998 999 999

[1000 rows x 1 columns]> ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  repr of class methods 264209937
335461386 https://github.com/pydata/xarray/issues/1620#issuecomment-335461386 https://api.github.com/repos/pydata/xarray/issues/1620 MDEyOklzc3VlQ29tbWVudDMzNTQ2MTM4Ng== fmaussion 10050469 2017-10-10T12:48:56Z 2017-10-10T12:48:56Z MEMBER

Some more live news from the classroom: it is indeed very confusing for more than one student. I think the repr should be simplified.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  repr of class methods 264209937

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 163.027ms · About: xarray-datasette