issue_comments

Table actions

4 rows where issue = 262874270 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix resample/interpolate for non-upsampling case · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
334526971 https://github.com/pydata/xarray/pull/1608#issuecomment-334526971 https://api.github.com/repos/pydata/xarray/issues/1608 MDEyOklzc3VlQ29tbWVudDMzNDUyNjk3MQ== darothen 4992424 2017-10-05T16:57:03Z 2017-10-05T16:57:03Z NONE

I'm a bit slow on the uptake here, but big 👍 from me. Thanks for catching this bug!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix resample/interpolate for non-upsampling case 262874270
334520871 https://github.com/pydata/xarray/pull/1608#issuecomment-334520871 https://api.github.com/repos/pydata/xarray/issues/1608 MDEyOklzc3VlQ29tbWVudDMzNDUyMDg3MQ== jhamman 2443309 2017-10-05T16:34:06Z 2017-10-05T16:34:06Z MEMBER

yes, this was a nice and easy fix. In the future, it may be nice to fast track no-op resample/interpolation since this does end up doing the same computation as it would if there were actual missing values but, this is a nice improvement for now.

Thanks again @darothen for the upsampling and resample refactor.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix resample/interpolate for non-upsampling case 262874270
334493935 https://github.com/pydata/xarray/pull/1608#issuecomment-334493935 https://api.github.com/repos/pydata/xarray/issues/1608 MDEyOklzc3VlQ29tbWVudDMzNDQ5MzkzNQ== jhamman 2443309 2017-10-05T15:05:16Z 2017-10-05T15:05:16Z MEMBER

@darothen - if this makes sense to you, we can let @shoyer give the final 👍 .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix resample/interpolate for non-upsampling case 262874270
334453965 https://github.com/pydata/xarray/pull/1608#issuecomment-334453965 https://api.github.com/repos/pydata/xarray/issues/1608 MDEyOklzc3VlQ29tbWVudDMzNDQ1Mzk2NQ== darothen 4992424 2017-10-05T12:46:54Z 2017-10-05T12:46:54Z NONE

Great catch; do you need any input from me @jhamman ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix resample/interpolate for non-upsampling case 262874270

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);