issue_comments

Thanks @guziy!

I think this is ready to go, any final objections?

LGTM. @crusaderky - I think you should look at this in conjunction with #1551.

Thanks @spencerahill

py.test seems to be working

Cheers

Try running them via pytest instead (pip install pytest or conda install pytest if you don't have it already).

Note that you'll need to add new test(s) that cover the modifications you have made -- not just run the existing tests.

Thanks @spencerahill:

I have run the flake8 test and modified the whats-new.rst. I think I need more guidance with the tests. I tried using nosetests and get the following exceptions (I am sure I am doing smth wrong here):

``` $ nosetests /Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/matplotlib/init.py:917: UserWarning: axes.hold is deprecated. Please remove it from your matplotlibrc and/or style files. warnings.warn(self.msg_depr_set % key) /Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/matplotlib/rcsetup.py:152: UserWarning: axes.hold is deprecated, will be removed in 3.0 warnings.warn("axes.hold is deprecated, will be removed in 3.0") E ====================================================================== ERROR: Failure: AttributeError (module 'pytest' has no attribute 'config')

Traceback (most recent call last): File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/failure.py", line 39, in runTest raise self.exc_val.with_traceback(self.tb) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/loader.py", line 417, in loadTestsFromName addr.filename, addr.module) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/importer.py", line 47, in importFromPath return self.importFromDir(dir_path, fqname) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/importer.py", line 94, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/imp.py", line 244, in load_module return load_package(name, filename) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/imp.py", line 216, in load_package return _load(spec) File "<frozen importlib._bootstrap>", line 675, in _load File "<frozen importlib._bootstrap>", line 655, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 678, in exec_module File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed File "/Users/huziy/PythonProjects/xarray/xarray/tests/init.py", line 130, in <module> _SKIP_FLAKY = not pytest.config.getoption("--run-flaky") AttributeError: module 'pytest' has no attribute 'config'

Ran 1 test in 0.582s

FAILED (errors=1) ```

Cheers

have not run tests yet

These will definitely be needed. Existing tests for open_mfdataset are in xarray/tests/test_backends.py. @shoyer and/or @jhamman can hopefully help you out if you need more guidance.

Not sure how to install flake8

pip install flake8 should work. Alternatively if you use conda conda install -c conda-forge flake8

Do not think the change is big enough to be added to the files

A brief note in What's New under the Enhancements section would actually be appropriate. Just follow the example of the others in that section.

Thanks for taking this on! We actually just bumped across this (here), so your fix will immediately benefit more than just you.