home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

18 rows where issue = 253463226 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 5

  • shoyer 10
  • jhamman 4
  • crusaderky 2
  • dopplershift 1
  • darothen 1

author_association 3

  • MEMBER 16
  • CONTRIBUTOR 1
  • NONE 1

issue 1

  • v0.10 Release · 18 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
345817363 https://github.com/pydata/xarray/issues/1535#issuecomment-345817363 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0NTgxNzM2Mw== shoyer 1217238 2017-11-20T20:13:51Z 2017-11-20T20:13:51Z MEMBER

I just merged the update on conda-forge: https://github.com/conda-forge/xarray-feedstock/pull/26

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
345796374 https://github.com/pydata/xarray/issues/1535#issuecomment-345796374 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0NTc5NjM3NA== crusaderky 6213168 2017-11-20T19:08:54Z 2017-11-20T19:08:54Z MEMBER

Awesome! Can we expect a conda build soon?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
345767630 https://github.com/pydata/xarray/issues/1535#issuecomment-345767630 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0NTc2NzYzMA== jhamman 2443309 2017-11-20T17:27:24Z 2017-11-20T17:27:24Z MEMBER

Great. Thanks @shoyer!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
345766070 https://github.com/pydata/xarray/issues/1535#issuecomment-345766070 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0NTc2NjA3MA== shoyer 1217238 2017-11-20T17:22:20Z 2017-11-20T17:22:20Z MEMBER

The release is tagged and on pypi: https://pypi.python.org/pypi/xarray

I'm waiting for read the docs to finish its rebuild before sending out an announcement to the mailing list.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
345590369 https://github.com/pydata/xarray/issues/1535#issuecomment-345590369 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0NTU5MDM2OQ== shoyer 1217238 2017-11-20T04:42:12Z 2017-11-20T04:42:12Z MEMBER

The second release candidate seems to have been received well. @benbovy and @fujiisoup fixed two issues (#1723 and #1724), but neither of them were actually introduced by rc2. So I think it's time to issue the final release. I'll do so tomorrow unless there are any objections.

{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
343766039 https://github.com/pydata/xarray/issues/1535#issuecomment-343766039 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0Mzc2NjAzOQ== shoyer 1217238 2017-11-12T20:42:26Z 2017-11-12T20:42:26Z MEMBER

We have a few more cleanup/bugfix PRs in progress that I think are almost ready to go in: https://github.com/pydata/xarray/pull/1710, https://github.com/pydata/xarray/pull/1707, https://github.com/pydata/xarray/pull/1705

I would like to merge these and then issue another release candidate.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
340662885 https://github.com/pydata/xarray/issues/1535#issuecomment-340662885 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0MDY2Mjg4NQ== shoyer 1217238 2017-10-31T05:18:33Z 2017-10-31T05:18:33Z MEMBER

The release candidate has been tagged and is on pypi. Docs are also up: http://xarray.pydata.org/en/v0.10.0rc1/whats-new.html

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
340653423 https://github.com/pydata/xarray/issues/1535#issuecomment-340653423 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0MDY1MzQyMw== shoyer 1217238 2017-10-31T03:59:05Z 2017-10-31T03:59:05Z MEMBER

OK, I'm going to issue the release candidate!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
340648806 https://github.com/pydata/xarray/issues/1535#issuecomment-340648806 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0MDY0ODgwNg== jhamman 2443309 2017-10-31T03:22:18Z 2017-10-31T03:22:18Z MEMBER

@shoyer - I just merged the last two PRs. We're feature complete for v0.10!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
340237546 https://github.com/pydata/xarray/issues/1535#issuecomment-340237546 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0MDIzNzU0Ng== shoyer 1217238 2017-10-29T04:51:49Z 2017-10-31T03:19:45Z MEMBER

I think we're down to the last few PRs, all of which are nearly ready to go in:

  • [x] #1657: fix warnings in the test suite
  • [x] #1667: tweaks to to_dask_dataframe
  • [x] #1669: fix errors that appear after updating to pandas 0.21
  • [x] #1670: reorganize/fix-up what's new (feedback would be appreciated!)

I plan to issue the RC as soon as all of these are merged.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
325497632 https://github.com/pydata/xarray/issues/1535#issuecomment-325497632 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDMyNTQ5NzYzMg== dopplershift 221526 2017-08-28T22:09:17Z 2017-10-28T01:25:57Z CONTRIBUTOR

Can we add: - [x] ENH: Support using opened netCDF4.Dataset (Fixes #1459) #1508

to that list?

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
340120817 https://github.com/pydata/xarray/issues/1535#issuecomment-340120817 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0MDEyMDgxNw== jhamman 2443309 2017-10-27T23:31:50Z 2017-10-27T23:31:50Z MEMBER

This all sounds good to me. There is also #1485 that can go in now. We were just waiting since it has some changes to the issue template on github.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
340120589 https://github.com/pydata/xarray/issues/1535#issuecomment-340120589 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDM0MDEyMDU4OQ== shoyer 1217238 2017-10-27T23:29:26Z 2017-10-27T23:29:26Z MEMBER

OK, I really want to get the release candidate (and the release) out promptly. https://github.com/pydata/xarray/issues/1663 in particular is going to be annoying for users with pandas 0.21 out.

I think https://github.com/pydata/xarray/pull/1615 (unicode string in netCDF3) and https://github.com/pydata/xarray/pull/1648 (vectorize=True in apply_ufunc) are ready to merge, and https://github.com/pydata/xarray/pull/1657 (warnings in test suite) is nearly so. Is there anything else we want to get in for 0.10?

The last outstanding PR from the top is #1489 (to_dask_dataframe()). I have a couple small tweaks to the design that I think we still need, but I think I'll merge it in the current state and add those tweaks in a follow-on PR.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
327842641 https://github.com/pydata/xarray/issues/1535#issuecomment-327842641 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDMyNzg0MjY0MQ== shoyer 1217238 2017-09-07T15:53:07Z 2017-09-08T19:28:10Z MEMBER

Yes.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
327833735 https://github.com/pydata/xarray/issues/1535#issuecomment-327833735 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDMyNzgzMzczNQ== jhamman 2443309 2017-09-07T15:23:20Z 2017-09-07T15:23:20Z MEMBER

@shoyer and @fujiisoup - are we going to take care of #1333 as part of #1473?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
325558564 https://github.com/pydata/xarray/issues/1535#issuecomment-325558564 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDMyNTU1ODU2NA== shoyer 1217238 2017-08-29T05:24:35Z 2017-08-29T05:24:35Z MEMBER

@fujiisoup is finishing up #1473 (vectorized indexing) but we still have one unresolved concern: existing uses of xarray objects to index other xarray objects will break in some cases, because the behavior of vectorized indexing will depend on dimension names and coordinates on indexer objects. In particular: behavior will change if the indexer object goes along a different dimension than the corresponding dimension of the indexed object (e.g., for array.sel(x=ind) if ind.dims != ('x',)).

Unfortunately, there isn't a good way to deprecate the existing behavior while introducing the new behavior, since the meaning of this type of indexing will change. We could do a deprecation cycle (https://github.com/pydata/xarray/issues/1333), but that will mean delaying this highly useful form of indexing.

For what it's worth, I think this the last major breaking change of this type that we will need for xarray. (Though we might choose to do some other clean-ups before the v1.0 release)

Are we OK with this breaking change for the 0.10 release? It would be accompanied by a large note under "Breaking changes" in the release notes.

(Free to express your opinion with 👍 or 👎 on this comment.)

{
    "total_count": 6,
    "+1": 6,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
325499818 https://github.com/pydata/xarray/issues/1535#issuecomment-325499818 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDMyNTQ5OTgxOA== crusaderky 6213168 2017-08-28T22:20:42Z 2017-08-28T22:20:42Z MEMBER

I'm hoping to find the time to do #1521 and #1523 too

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226
325494110 https://github.com/pydata/xarray/issues/1535#issuecomment-325494110 https://api.github.com/repos/pydata/xarray/issues/1535 MDEyOklzc3VlQ29tbWVudDMyNTQ5NDExMA== darothen 4992424 2017-08-28T21:52:54Z 2017-08-28T21:52:54Z NONE

Great; there's only a single action item left on #1272, so I'll try to get to that later this week.

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10 Release 253463226

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 12.714ms · About: xarray-datasette