issue_comments

Table actions

7 rows where issue = 248273793 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Plotting datasets with variable coordinates · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
511260354 https://github.com/pydata/xarray/issues/1503#issuecomment-511260354 https://api.github.com/repos/pydata/xarray/issues/1503 MDEyOklzc3VlQ29tbWVudDUxMTI2MDM1NA== hetland 2599958 2019-07-15T02:44:54Z 2019-07-15T02:44:54Z NONE

To follow up with this, plotting using 'x' and 'y' kwargs works fine for now, even when the variable coordinates do not share the same number of dimensions. (i.e., a common case of plotting a cross section with sigma- or s-coordinates where the horizontal variable is 1D, but the vertical variable is 2D). So, I think this great, and should cover most use cases.

The only approach I can think of to do this automatically would be to find variable coordinates that have matching dimensions. This would probably work in lots of cases, but unexpectedly break in others. I think I would prefer explicit over clever, unless we can think of a way to do it that won't break.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting datasets with variable coordinates 248273793
511004392 https://github.com/pydata/xarray/issues/1503#issuecomment-511004392 https://api.github.com/repos/pydata/xarray/issues/1503 MDEyOklzc3VlQ29tbWVudDUxMTAwNDM5Mg== rabernat 1197350 2019-07-12T19:23:21Z 2019-07-12T19:23:21Z MEMBER

@kthyng & @hetland: this issue is related to our lunch discussion today about how to automatically use multidimensional coordinates when plotting.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting datasets with variable coordinates 248273793
370881453 https://github.com/pydata/xarray/issues/1503#issuecomment-370881453 https://api.github.com/repos/pydata/xarray/issues/1503 MDEyOklzc3VlQ29tbWVudDM3MDg4MTQ1Mw== dcherian 2448579 2018-03-06T18:32:11Z 2018-03-06T18:32:11Z MEMBER

Shall I send in a PR to check da.variables then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting datasets with variable coordinates 248273793
370594116 https://github.com/pydata/xarray/issues/1503#issuecomment-370594116 https://api.github.com/repos/pydata/xarray/issues/1503 MDEyOklzc3VlQ29tbWVudDM3MDU5NDExNg== fmaussion 10050469 2018-03-05T22:42:24Z 2018-03-05T22:42:24Z MEMBER

No it doesn't! Your most recent PR still checks for the kwarg in dims, not in coordinates.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting datasets with variable coordinates 248273793
370590107 https://github.com/pydata/xarray/issues/1503#issuecomment-370590107 https://api.github.com/repos/pydata/xarray/issues/1503 MDEyOklzc3VlQ29tbWVudDM3MDU5MDEwNw== dcherian 2448579 2018-03-05T22:27:52Z 2018-03-05T22:27:52Z MEMBER

Does this work now?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting datasets with variable coordinates 248273793
321420237 https://github.com/pydata/xarray/issues/1503#issuecomment-321420237 https://api.github.com/repos/pydata/xarray/issues/1503 MDEyOklzc3VlQ29tbWVudDMyMTQyMDIzNw== smillerc 1474554 2017-08-10T00:51:34Z 2017-08-10T00:51:34Z NONE

I think that would work. I've just been trying to understand what the CF conventions mean for me in my use case, where I have a grid that moves over time, but keeps the same number of nodes and cells. I feel like xarray could be a big help, but I'm still trying to figure it out.

Thanks for the quick responses here and on SO.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting datasets with variable coordinates 248273793
320535308 https://github.com/pydata/xarray/issues/1503#issuecomment-320535308 https://api.github.com/repos/pydata/xarray/issues/1503 MDEyOklzc3VlQ29tbWVudDMyMDUzNTMwOA== fmaussion 10050469 2017-08-06T21:53:16Z 2017-08-06T21:54:24Z MEMBER

On 08/06/2017 11:37 PM, Sam Miller wrote:

Is the behavior that xarray is showing by design or is it a corner case that I'm getting because I'm not using xarray in the way it was originally intended?

Xarray follows the CF conventions as far as possible, and the convention states that dimension coordinates should have the same name as their dimension. See the docs for terminology: http://xarray.pydata.org/en/latest/data-structures.html#coordinates

What we could do however is to add a "x" kwarg to plot.line so that one can specify which coordinate to use for the plot, like plot.pcolormesh

i.e. it would be possible to do:

ds.variable.plot(x='r')

Instead of renaming the dimension for it to become a dimension coordinate.

Thoughts?

Cheers,

Fabien

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting datasets with variable coordinates 248273793

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);