issue_comments

Table actions

8 rows where issue = 239636285 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Center the coordinates to pixels for rasterio backend · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
313232619 https://github.com/pydata/xarray/pull/1468#issuecomment-313232619 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMzIzMjYxOQ== shoyer 1217238 2017-07-05T21:30:51Z 2017-07-05T21:30:51Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285
313232313 https://github.com/pydata/xarray/pull/1468#issuecomment-313232313 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMzIzMjMxMw== PeterDSteinberg 1445602 2017-07-05T21:29:31Z 2017-07-05T21:29:31Z NONE

+1 from me as well. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285
313202568 https://github.com/pydata/xarray/pull/1468#issuecomment-313202568 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMzIwMjU2OA== shoyer 1217238 2017-07-05T19:28:21Z 2017-07-05T19:28:21Z MEMBER

I'm not sure we really have a cell centering convention for xarray, except for plotting routines, where we chose the cell-centered convention from CF-conventions. But this does seem like a marginal improvement, so +1 from me.

In the future we may want to switch to describing bounds fully using IntervalIndex from the latest release of pandas. But the API there is still being sorted out along with some bug fixes (see https://github.com/pandas-dev/pandas/pull/16386), so it's probably better to stick with this for now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285
313180221 https://github.com/pydata/xarray/pull/1468#issuecomment-313180221 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMzE4MDIyMQ== gbrener 2840348 2017-07-05T18:01:28Z 2017-07-05T18:01:28Z CONTRIBUTOR

Thanks for the feedback @fmaussion . I addressed your suggestions and made some small cleanups. Please let me know if there's anything else.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285
312423189 https://github.com/pydata/xarray/pull/1468#issuecomment-312423189 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMjQyMzE4OQ== fmaussion 10050469 2017-07-01T10:04:38Z 2017-07-01T10:04:38Z MEMBER

Definitely a bad bug which could justify a minor release soon :-(

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285
312370884 https://github.com/pydata/xarray/pull/1468#issuecomment-312370884 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMjM3MDg4NA== gbrener 2840348 2017-06-30T20:55:31Z 2017-06-30T20:55:31Z CONTRIBUTOR

Thanks for the feedback @jhamman - just added the documentation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285
312310875 https://github.com/pydata/xarray/pull/1468#issuecomment-312310875 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMjMxMDg3NQ== jhamman 2443309 2017-06-30T16:17:57Z 2017-06-30T16:17:57Z MEMBER

Thanks for the PR. I'll let @fmaussion comment on the substance here but given the confusion and the change in behavior, let's add a note in whats-new.rst and in the open_rasterio() doc string.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285
312144355 https://github.com/pydata/xarray/pull/1468#issuecomment-312144355 https://api.github.com/repos/pydata/xarray/issues/1468 MDEyOklzc3VlQ29tbWVudDMxMjE0NDM1NQ== jbednar 1695496 2017-06-30T00:40:20Z 2017-06-30T00:40:39Z CONTRIBUTOR

Looks good to me, and very important (for those of us who care about half a pixel! :-)...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Center the coordinates to pixels for rasterio backend 239636285

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);