home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where issue = 238990919 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • fmaussion · 3 ✖

issue 1

  • CF conventions for time doesn't support years · 3 ✖

author_association 1

  • MEMBER 3
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
319325871 https://github.com/pydata/xarray/issues/1467#issuecomment-319325871 https://api.github.com/repos/pydata/xarray/issues/1467 MDEyOklzc3VlQ29tbWVudDMxOTMyNTg3MQ== fmaussion 10050469 2017-08-01T09:57:42Z 2017-08-02T16:05:15Z MEMBER

Hi Matthias, I think your solution is fine. The best is simply to avoid "months" as units altogether.

If one has a "real" calendar one can also let pandas and xarray do the job:

python t = pd.date_range(start='1980-01', end='2010-12', freq='MS') target = np.random.rand(len(t), 10, 10) lat = np.arange(50, 51, 0.1) lon = np.arange(3, 4, 0.1) target_xr = xr.Dataset({'test': (['time', 'lat', 'lon'], target)}, coords={'time': ('time', t), 'lat': lat, 'lon': lon} ) target_xr.to_netcdf('test_2.nc') which creates the following time units automatically:

int64 time(time) ; time:units = "days since 1980-01-01 00:00:00" ; time:calendar = "proleptic_gregorian" ;

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  CF conventions for time doesn't support years 238990919
311634421 https://github.com/pydata/xarray/issues/1467#issuecomment-311634421 https://api.github.com/repos/pydata/xarray/issues/1467 MDEyOklzc3VlQ29tbWVudDMxMTYzNDQyMQ== fmaussion 10050469 2017-06-28T11:36:37Z 2017-06-28T11:36:37Z MEMBER

I think I do mean 'years' in the CF convention sense

Can you pinpoint to which part of the CF convention? From the link I read: a year is exactly 365.242198781 days, which would lead to highly unlikely calendar dates.

I agree however that interpreting "years" as being "calendar years" is the only way that makes sense.

For the record, netCDF4 also doesn't like "years":

```python import netCDF4 ds = netCDF4.Dataset('/home/mowglie/Downloads/histsoc_population_0.5deg_1861-2005.nc4') time = ds.variables['time'] netCDF4.num2date(time[:], units=time.units)


ValueError Traceback (most recent call last) <ipython-input-15-b38f64c7bce4> in <module>() 2 ds = netCDF4.Dataset('histsoc_population_0.5deg_1861-2005.nc4') 3 time = ds.variables['time'] ----> 4 netCDF4.num2date(time[:], units=time.units)

netCDF4/_netCDF4.pyx in netCDF4._netCDF4.num2date (netCDF4/_netCDF4.c:66463)()

ValueError: unsupported time units ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  CF conventions for time doesn't support years 238990919
311620076 https://github.com/pydata/xarray/issues/1467#issuecomment-311620076 https://api.github.com/repos/pydata/xarray/issues/1467 MDEyOklzc3VlQ29tbWVudDMxMTYyMDA3Ng== fmaussion 10050469 2017-06-28T10:24:36Z 2017-06-28T10:24:36Z MEMBER

I am not sure to understand what you are asking us to do here. The problem with "years" is that their use is not recommended by the CF conventions.

Very often (and I think your file means it this way), users would like years to be simple "calendar years" , i.e. : 1901-01-01, 1902-01-01, but this is not what the unit "years" means in the CF conventions: see http://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html#time-coordinate

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  CF conventions for time doesn't support years 238990919

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 883.937ms · About: xarray-datasette