issue_comments

Table actions

8 rows where issue = 237807730 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • copy / deepcopy not deepcopying coords? · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
509445160 https://github.com/pydata/xarray/issues/1463#issuecomment-509445160 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDUwOTQ0NTE2MA== max-sixty 5635139 2019-07-09T00:54:02Z 2019-07-09T01:05:53Z MEMBER

This is fixed! It's not allowing attrs to be passed into _replace. ~I'll open a new issue~ I think that's OK, since attrs are on the variable rather than the DataArray

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730
509444525 https://github.com/pydata/xarray/issues/1463#issuecomment-509444525 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDUwOTQ0NDUyNQ== shoyer 1217238 2019-07-09T00:49:48Z 2019-07-09T00:50:09Z MEMBER

I think this was fixed by https://github.com/pydata/xarray/pull/2936. Certainly I can't reproduce the example in the first comment here any more.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730
509319403 https://github.com/pydata/xarray/issues/1463#issuecomment-509319403 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDUwOTMxOTQwMw== max-sixty 5635139 2019-07-08T17:30:17Z 2019-07-08T17:30:17Z MEMBER

This also doesn't work for ._replace: https://github.com/pydata/xarray/blob/master/xarray/core/dataarray.py#L296

So my comment here isn't really correct: https://github.com/pydata/xarray/pull/3086#discussion_r301211375

@pletchm should I have a go at a PR? Happy to take this and you can take another one; I have lots of time atm

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730
482732837 https://github.com/pydata/xarray/issues/1463#issuecomment-482732837 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDQ4MjczMjgzNw== max-sixty 5635139 2019-04-12T21:44:52Z 2019-04-12T21:44:52Z MEMBER

Great @pletchm ! This is a example of a recent similar issue: https://github.com/pydata/xarray/pull/2839/files

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730
482701114 https://github.com/pydata/xarray/issues/1463#issuecomment-482701114 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDQ4MjcwMTExNA== dcherian 2448579 2019-04-12T19:50:29Z 2019-04-12T19:50:29Z MEMBER

go for it! @pletchm .

Feel free to open a PR or ask questions if you need help.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730
482696887 https://github.com/pydata/xarray/issues/1463#issuecomment-482696887 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDQ4MjY5Njg4Nw== pletchm 10720577 2019-04-12T19:35:04Z 2019-04-12T19:35:04Z CONTRIBUTOR

I'd like to take a shot fixing this bug unless someone else already is working on it. Would that be alright?

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730
340454702 https://github.com/pydata/xarray/issues/1463#issuecomment-340454702 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDM0MDQ1NDcwMg== fujiisoup 6815844 2017-10-30T14:08:08Z 2017-10-30T14:08:08Z MEMBER

We do not allow to assign value in IndexVariable as pandas.Index is immutable (assigning value raises a TypeError), but we can actually do this from .data attribute (this line). (Our IndexVariable is not immutable...)

I think we should copy also IndexVariable not keeping the original reference.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730
310489331 https://github.com/pydata/xarray/issues/1463#issuecomment-310489331 https://api.github.com/repos/pydata/xarray/issues/1463 MDEyOklzc3VlQ29tbWVudDMxMDQ4OTMzMQ== shoyer 1217238 2017-06-22T20:12:10Z 2017-06-22T20:12:10Z MEMBER

This seems like a bug.

I suspect the problem is in Variable.copy on these lines (which should probably just be removed). Coordinates store their data in pandas.Index objects, which are supposed to be immutable. But apparently that's not necessarily the case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy / deepcopy not deepcopying coords? 237807730

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);