issue_comments

Table actions

5 rows where issue = 237008177 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • groupby should still squeeze for non-monotonic inputs · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1059546596 https://github.com/pydata/xarray/issues/1460#issuecomment-1059546596 https://api.github.com/repos/pydata/xarray/issues/1460 IC_kwDOAMm_X84_J2Xk shoyer 1217238 2022-03-04T21:31:41Z 2022-03-04T21:31:41Z MEMBER

Well, even if we keep squeeze as an option, I think squeeze=False would be much more consistent default behavior :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   groupby should still squeeze for non-monotonic inputs 237008177
1059506992 https://github.com/pydata/xarray/issues/1460#issuecomment-1059506992 https://api.github.com/repos/pydata/xarray/issues/1460 IC_kwDOAMm_X84_Jssw relativistic 371039 2022-03-04T20:30:22Z 2022-03-04T20:30:22Z NONE

Just wanted to mention I just got tripped up by this. It took me a long time to figure out why my code wasn't working like the groupby example. It took a lot of trial and error to figure out the problem was one of my dims wasn't sorted. It was a categorical string-based dim that you wouldn't think to sort.

I personally find squeeze a convenient option when applying map. FWIW, it would break some of my code if the default behavior were to change (I'm using map to apply some mathematical code that expects 2d matrix input. The DataArray is 3D, where the third dimension is a label for each 2d matrix). Easy to adapt the code, but I wanted to point out a case where squeeze is what you want. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   groupby should still squeeze for non-monotonic inputs 237008177
766420609 https://github.com/pydata/xarray/issues/1460#issuecomment-766420609 https://api.github.com/repos/pydata/xarray/issues/1460 MDEyOklzc3VlQ29tbWVudDc2NjQyMDYwOQ== shoyer 1217238 2021-01-24T19:49:28Z 2021-01-24T19:49:28Z MEMBER

A better long term solution is probably removing "squeeze" from groupby entirely: https://github.com/pydata/xarray/issues/2157

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   groupby should still squeeze for non-monotonic inputs 237008177
766370481 https://github.com/pydata/xarray/issues/1460#issuecomment-766370481 https://api.github.com/repos/pydata/xarray/issues/1460 MDEyOklzc3VlQ29tbWVudDc2NjM3MDQ4MQ== dsh0 33100676 2021-01-24T15:44:40Z 2021-01-24T15:44:40Z NONE

I'd like add that the groupby docstring never mention that squeezing only works for monotonic index (which is an unreasonable restriction in the first place)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   groupby should still squeeze for non-monotonic inputs 237008177
700359637 https://github.com/pydata/xarray/issues/1460#issuecomment-700359637 https://api.github.com/repos/pydata/xarray/issues/1460 MDEyOklzc3VlQ29tbWVudDcwMDM1OTYzNw== stale[bot] 26384082 2020-09-29T00:51:13Z 2020-09-29T00:51:13Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   groupby should still squeeze for non-monotonic inputs 237008177

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);