issue_comments

Table actions

5 rows where issue = 234658224 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Package naming "conventions" for xarray extensions · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
497113360 https://github.com/pydata/xarray/issues/1447#issuecomment-497113360 https://api.github.com/repos/pydata/xarray/issues/1447 MDEyOklzc3VlQ29tbWVudDQ5NzExMzM2MA== stale[bot] 26384082 2019-05-29T21:20:14Z 2019-05-29T21:20:14Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Package naming "conventions" for xarray extensions 234658224
309461142 https://github.com/pydata/xarray/issues/1447#issuecomment-309461142 https://api.github.com/repos/pydata/xarray/issues/1447 MDEyOklzc3VlQ29tbWVudDMwOTQ2MTE0Mg== spencerahill 6200806 2017-06-19T14:42:35Z 2017-06-19T14:42:35Z CONTRIBUTOR

One other thought for x rather than xr: to me at least, the x-prefixed package names just sound cool 😄 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Package naming "conventions" for xarray extensions 234658224
309392780 https://github.com/pydata/xarray/issues/1447#issuecomment-309392780 https://api.github.com/repos/pydata/xarray/issues/1447 MDEyOklzc3VlQ29tbWVudDMwOTM5Mjc4MA== benbovy 4160723 2017-06-19T09:51:39Z 2017-06-19T09:51:39Z MEMBER

I like the idea of using only the x prefix for both the package-import name and the accessor. xr doesn't look very nice as a prefix with no underscore. Maybe having the x prefix for the accessor as well would also differentiate 3rd-party accessors from xarray-specific accessors like dt?

I don't have strong opinions on this either.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Package naming "conventions" for xarray extensions 234658224
308914123 https://github.com/pydata/xarray/issues/1447#issuecomment-308914123 https://api.github.com/repos/pydata/xarray/issues/1447 MDEyOklzc3VlQ29tbWVudDMwODkxNDEyMw== darothen 4992424 2017-06-16T02:14:31Z 2017-06-16T02:14:31Z NONE

For xbpch I followed a similar naming convention based on @rabernat's xmitgcm. Brewing on the horizon is an xarray-powered toolkit for GEOS-Chem and while it'll be a stand-alone library, I imagine it'll belong to this confederation of toolkits and provide an accessor or two for computing model grid geometries and related things on-the-fly. I'd also +1 for an xarray prefix (so, xbpch -> xarray-bpch and xmitgcm -> xarray-mitgcm?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Package naming "conventions" for xarray extensions 234658224
308823486 https://github.com/pydata/xarray/issues/1447#issuecomment-308823486 https://api.github.com/repos/pydata/xarray/issues/1447 MDEyOklzc3VlQ29tbWVudDMwODgyMzQ4Ng== jhamman 2443309 2017-06-15T18:08:54Z 2017-06-15T18:08:54Z MEMBER

@benbovy -

I don't have really strong opinions here but I can tell you what I've done with xmap. I basically tried to keep it simple and use the same name for all three (package full name, package import name, and the accessor name). My thoughts on how to handle longer names are generally the same, the package-full name could be anything (I'd be okay switching to xarray-mapping) and I like the idea of having an identifiable collection of extensions (+1 for xarray prefix). My gut reaction to xrsignal is to drop the r (xsignal) and perhaps to use xsignal as the accessor name as well. Just some thoughts and like I said, no strong opinions here.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Package naming "conventions" for xarray extensions 234658224

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);