issue_comments

Table actions

4 rows where issue = 221855729 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • indexing error in sel subsets · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
298803481 https://github.com/pydata/xarray/issues/1374#issuecomment-298803481 https://api.github.com/repos/pydata/xarray/issues/1374 MDEyOklzc3VlQ29tbWVudDI5ODgwMzQ4MQ== shoyer 1217238 2017-05-03T01:19:36Z 2017-05-03T01:19:36Z MEMBER

There's not really an elegant solution here, but I'll figure something out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   indexing error in sel subsets 221855729
295578094 https://github.com/pydata/xarray/issues/1374#issuecomment-295578094 https://api.github.com/repos/pydata/xarray/issues/1374 MDEyOklzc3VlQ29tbWVudDI5NTU3ODA5NA== shoyer 1217238 2017-04-20T04:37:18Z 2017-04-20T04:37:38Z MEMBER

The issue appears to be in our internal CopyOnWriteArray and MemoryCachedArray classes. When the wrapped array is a scalar string, indexing with an empty tuple doesn't work properly: ``` In [14]: from xarray.core.indexing import CopyOnWriteArray, MemoryCachedArray

In [15]: x = CopyOnWriteArray(np.array([1, 2, 3]))

In [16]: x[0] Out[16]: CopyOnWriteArray(array=1)

In [17]: x[0][()] Out[17]: CopyOnWriteArray(array=1)

In [18]: x = CopyOnWriteArray(np.array(['foo', 'bar']))

In [19]: x[0] Out[19]: CopyOnWriteArray(array='foo')

In [20]: x[0][()]

TypeError Traceback (most recent call last) <ipython-input-20-e2b82e9c4874> in <module>() ----> 1 x[0][()]

/Users/shoyer/dev/xarray/xarray/core/indexing.py in getitem(self, key) 401 402 def getitem(self, key): --> 403 return type(self)(self.array[key]) 404 405 def setitem(self, key, value):

TypeError: string indices must be integers `` In some sense, the source issue is thatx[()]` works for numpy scalar numbers, but not strings.

I will see if I can come up with an elegant fix...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   indexing error in sel subsets 221855729
295576554 https://github.com/pydata/xarray/issues/1374#issuecomment-295576554 https://api.github.com/repos/pydata/xarray/issues/1374 MDEyOklzc3VlQ29tbWVudDI5NTU3NjU1NA== shoyer 1217238 2017-04-20T04:25:33Z 2017-04-20T04:25:33Z MEMBER

Marking this as a bug. I can reproduce this locally on master.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   indexing error in sel subsets 221855729
294251213 https://github.com/pydata/xarray/issues/1374#issuecomment-294251213 https://api.github.com/repos/pydata/xarray/issues/1374 MDEyOklzc3VlQ29tbWVudDI5NDI1MTIxMw== shoyer 1217238 2017-04-14T22:49:49Z 2017-04-14T22:49:49Z MEMBER

Are you using netCDF4 or scipy to read this data? Can you post a small file that illustrates the issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   indexing error in sel subsets 221855729

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);