issue_comments

Table actions

8 rows where issue = 221366244 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Weighted quantile · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
475055360 https://github.com/pydata/xarray/issues/1371#issuecomment-475055360 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDQ3NTA1NTM2MA== shoyer 1217238 2019-03-20T22:34:22Z 2019-03-20T22:34:22Z MEMBER

NumPy does have a pretty bad review back-log :(

On Fri, Mar 15, 2019 at 11:01 AM chunweiyuan notifications@github.com wrote:

My personal hope is to keep this thread open just for the record. But given the non-activity on the numpy end, I honestly can't promise any resolution to this issue in the near future. Thanks!

PS I persist because some people do seem to appreciate that PR and have forked it for their own use :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/1371#issuecomment-473387146, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1gzAFmpKOTSi0ljefC46A79vp8m1ks5vW9_8gaJpZM4M73c4 . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Weighted quantile 221366244
473387146 https://github.com/pydata/xarray/issues/1371#issuecomment-473387146 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDQ3MzM4NzE0Ng== chunweiyuan 5572303 2019-03-15T18:01:31Z 2019-03-15T18:01:31Z CONTRIBUTOR

My personal hope is to keep this thread open just for the record. But given the non-activity on the numpy end, I honestly can't promise any resolution to this issue in the near future. Thanks!

PS I persist because some people do seem to appreciate that PR and have forked it for their own use :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Weighted quantile 221366244
473082490 https://github.com/pydata/xarray/issues/1371#issuecomment-473082490 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDQ3MzA4MjQ5MA== max-sixty 5635139 2019-03-14T22:02:03Z 2019-03-14T22:02:03Z MEMBER

Would you like to leave this open @chunweiyuan ?

That's quite a thread! I'm impressed by your persistence

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Weighted quantile 221366244
473033854 https://github.com/pydata/xarray/issues/1371#issuecomment-473033854 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDQ3MzAzMzg1NA== chunweiyuan 5572303 2019-03-14T19:52:33Z 2019-03-14T19:52:33Z CONTRIBUTOR

So, as per suggestion by Stephan, I submitted the PR to numpy instead: https://github.com/numpy/numpy/pull/9211

Despite having possibly the highest number of comments of all active numpy PRs and passing all the tests, it's been sitting in limbo for the last few months. There seems to be quite some uncertainty about what to do with it, and the discussion has gone off tangent a bit to more upstream issues.

My hope is still to have it eventually merged into numpy, so that it could be easily ported to xarray. It's proven to be quite useful to my coworkers, as well as some of the numpy users. I believe it'll also serve xarray well. Thank you all for your patience.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
   Weighted quantile 221366244
472666131 https://github.com/pydata/xarray/issues/1371#issuecomment-472666131 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDQ3MjY2NjEzMQ== dcherian 2448579 2019-03-14T01:14:43Z 2019-03-14T01:14:43Z MEMBER

We could also add things like this to a cookbook section in the docs

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Weighted quantile 221366244
472640831 https://github.com/pydata/xarray/issues/1371#issuecomment-472640831 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDQ3MjY0MDgzMQ== stale[bot] 26384082 2019-03-13T23:06:58Z 2019-03-13T23:06:58Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Weighted quantile 221366244
293730368 https://github.com/pydata/xarray/issues/1371#issuecomment-293730368 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDI5MzczMDM2OA== chunweiyuan 5572303 2017-04-12T22:56:42Z 2017-04-12T22:56:42Z CONTRIBUTOR

Cool, let me toss it out on the numpy board and see what they think.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Weighted quantile 221366244
293726771 https://github.com/pydata/xarray/issues/1371#issuecomment-293726771 https://api.github.com/repos/pydata/xarray/issues/1371 MDEyOklzc3VlQ29tbWVudDI5MzcyNjc3MQ== shoyer 1217238 2017-04-12T22:35:48Z 2017-04-12T22:35:48Z MEMBER

I'm sure this is useful, but we try to avoid putting new numeric methods in xarray itself. Would the underlying weighted quantile method (on NumPy arrays) be appropriate for numpy or scipy? Then we might consider adding a wrapper function in xarray (though again, we have to be cautious to avoid overloading xarray with too many methods).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Weighted quantile 221366244

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);