issue_comments

Table actions

6 rows where issue = 219611498 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Cannot import xarray.tests due to use of pytest.config · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
292260729 https://github.com/pydata/xarray/issues/1353#issuecomment-292260729 https://api.github.com/repos/pydata/xarray/issues/1353 MDEyOklzc3VlQ29tbWVudDI5MjI2MDcyOQ== jjhelmus 1050278 2017-04-06T18:12:18Z 2017-04-06T18:12:18Z CONTRIBUTOR

@shoyer Agreed, there is no need for xarray.tests to be importable. Closing this issue, thanks for the quick clarification.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot import xarray.tests due to use of pytest.config 219611498
292237368 https://github.com/pydata/xarray/issues/1353#issuecomment-292237368 https://api.github.com/repos/pydata/xarray/issues/1353 MDEyOklzc3VlQ29tbWVudDI5MjIzNzM2OA== shoyer 1217238 2017-04-06T16:57:00Z 2017-04-06T16:57:00Z MEMBER

@jjhelmus see conda-forge/xarray-feedstock#20

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot import xarray.tests due to use of pytest.config 219611498
292236298 https://github.com/pydata/xarray/issues/1353#issuecomment-292236298 https://api.github.com/repos/pydata/xarray/issues/1353 MDEyOklzc3VlQ29tbWVudDI5MjIzNjI5OA== shoyer 1217238 2017-04-06T16:53:11Z 2017-04-06T16:53:11Z MEMBER

@jjhelmus Agreed! For testing public API, being able to import xarray and xarray.backends should be enough.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot import xarray.tests due to use of pytest.config 219611498
292195182 https://github.com/pydata/xarray/issues/1353#issuecomment-292195182 https://api.github.com/repos/pydata/xarray/issues/1353 MDEyOklzc3VlQ29tbWVudDI5MjE5NTE4Mg== jjhelmus 1050278 2017-04-06T14:38:57Z 2017-04-06T14:38:57Z CONTRIBUTOR

Just out of curiosity, what reason did you have for importing xarray.tests?

xarray.tests is listed as a import test in the conda-forge xarray-feedstock and was failing when I was doing a build. I do not think that import line needs to be present, tests does not seem to be in the public API of xarray. I'd be in favor of removing that line and keeping the test suite setup as-is.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot import xarray.tests due to use of pytest.config 219611498
292089134 https://github.com/pydata/xarray/issues/1353#issuecomment-292089134 https://api.github.com/repos/pydata/xarray/issues/1353 MDEyOklzc3VlQ29tbWVudDI5MjA4OTEzNA== shoyer 1217238 2017-04-06T07:13:59Z 2017-04-06T07:13:59Z MEMBER

Hmm. This seems like an easy way to add a few options to running our test suite, but maybe there is a better way to do this? I guess we could hack in a fallback with hasattr() but that's pretty ugly.

Just out of curiosity, what reason did you have for importing xarray.tests?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot import xarray.tests due to use of pytest.config 219611498
291901003 https://github.com/pydata/xarray/issues/1353#issuecomment-291901003 https://api.github.com/repos/pydata/xarray/issues/1353 MDEyOklzc3VlQ29tbWVudDI5MTkwMTAwMw== jjhelmus 1050278 2017-04-05T15:36:00Z 2017-04-05T15:36:00Z CONTRIBUTOR

pytest-dev/pytest#472 from BitBucket #472 seems to touch on this topic and references the note found at the end of the skip and xfail documentation:

You cannot use pytest.config.getvalue() in code imported before pytest’s argument parsing takes place. For example, conftest.py files are imported before command line parsing and thus config.getvalue() will not execute correctly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot import xarray.tests due to use of pytest.config 219611498

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);