issue_comments

Table actions

10 rows where issue = 218942553 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Add persist method to DataSet · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
291552880 https://github.com/pydata/xarray/pull/1349#issuecomment-291552880 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTU1Mjg4MA== rabernat 1197350 2017-04-04T16:19:20Z 2017-04-04T16:19:20Z MEMBER

I'm glad to see your first commit on the xarray side :).

Hopefully the first of many!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291552859 https://github.com/pydata/xarray/pull/1349#issuecomment-291552859 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTU1Mjg1OQ== mrocklin 306380 2017-04-04T16:19:17Z 2017-04-04T16:19:17Z MEMBER

Happy to contribute :)

On Tue, Apr 4, 2017 at 12:15 PM, Stephan Hoyer notifications@github.com wrote:

Thanks @mrocklin https://github.com/mrocklin!

I'm glad to see your first commit on the xarray side :).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1349#issuecomment-291551708, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszLwitqAEZCJ2mQurx8GDwQNlbMayks5rsmymgaJpZM4Mxk7K . 

{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291551708 https://github.com/pydata/xarray/pull/1349#issuecomment-291551708 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTU1MTcwOA== shoyer 1217238 2017-04-04T16:15:31Z 2017-04-04T16:15:31Z MEMBER

Thanks @mrocklin!

I'm glad to see your first commit on the xarray side :).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291549965 https://github.com/pydata/xarray/pull/1349#issuecomment-291549965 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTU0OTk2NQ== rabernat 1197350 2017-04-04T16:10:09Z 2017-04-04T16:10:09Z MEMBER

This looks good to go from my point of view!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291524501 https://github.com/pydata/xarray/pull/1349#issuecomment-291524501 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTUyNDUwMQ== mrocklin 306380 2017-04-04T14:50:57Z 2017-04-04T14:50:57Z MEMBER

Added docs. Also removed section on dask.array not providing automatic chunk alignment (this is now supported)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291517534 https://github.com/pydata/xarray/pull/1349#issuecomment-291517534 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTUxNzUzNA== rabernat 1197350 2017-04-04T14:29:08Z 2017-04-04T14:29:08Z MEMBER

Would also probably be good to document this a bit in the section on dask: https://github.com/pydata/xarray/blob/master/doc/dask.rst

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291489495 https://github.com/pydata/xarray/pull/1349#issuecomment-291489495 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTQ4OTQ5NQ== mrocklin 306380 2017-04-04T12:50:20Z 2017-04-04T12:50:20Z MEMBER

Added DataArray.persist and a whats new entry

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291384544 https://github.com/pydata/xarray/pull/1349#issuecomment-291384544 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTM4NDU0NA== shoyer 1217238 2017-04-04T03:35:15Z 2017-04-04T03:35:15Z MEMBER

Thanks @mrocklin! This is a great start.

Yes, it would be great to have this on DataArray as well. The implementation would be a two liner: def persist(self): ds = self._to_temp_dataset().persist() return self._from_temp_dataset(ds)

I just pushed a commit to master adding a "what's new" template for v0.9.3.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291382124 https://github.com/pydata/xarray/pull/1349#issuecomment-291382124 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTM4MjEyNA== rabernat 1197350 2017-04-04T03:13:16Z 2017-04-04T03:13:16Z MEMBER

Would it make sense to have persist for DataArrays as well? My opinion is: yes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553
291151666 https://github.com/pydata/xarray/pull/1349#issuecomment-291151666 https://api.github.com/repos/pydata/xarray/issues/1349 MDEyOklzc3VlQ29tbWVudDI5MTE1MTY2Ng== mrocklin 306380 2017-04-03T13:59:43Z 2017-04-03T13:59:43Z MEMBER

I suspect that there is more to do here, but I wanted to get the ball rolling on this.

cc @shoyer @rabernat @pwolfram 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add persist method to DataSet 218942553

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);