issue_comments

Table actions

7 rows where issue = 218291642 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Ensures drop=True case works with empty mask · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
291020601 https://github.com/pydata/xarray/pull/1342#issuecomment-291020601 https://api.github.com/repos/pydata/xarray/issues/1342 MDEyOklzc3VlQ29tbWVudDI5MTAyMDYwMQ== pwolfram 4295853 2017-04-02T22:45:01Z 2017-04-02T22:45:01Z CONTRIBUTOR

Thanks @shoyer!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensures drop=True case works with empty mask 218291642
290987246 https://github.com/pydata/xarray/pull/1342#issuecomment-290987246 https://api.github.com/repos/pydata/xarray/issues/1342 MDEyOklzc3VlQ29tbWVudDI5MDk4NzI0Ng== pwolfram 4295853 2017-04-02T13:43:23Z 2017-04-02T13:43:23Z CONTRIBUTOR

@shoyer, the bug fix note has now been added and commits merged! Thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensures drop=True case works with empty mask 218291642
290755765 https://github.com/pydata/xarray/pull/1342#issuecomment-290755765 https://api.github.com/repos/pydata/xarray/issues/1342 MDEyOklzc3VlQ29tbWVudDI5MDc1NTc2NQ== shoyer 1217238 2017-03-31T16:07:35Z 2017-03-31T16:07:35Z MEMBER

can you add a brief bug fix note for what's new? that seems to have gotten lost...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensures drop=True case works with empty mask 218291642
290755379 https://github.com/pydata/xarray/pull/1342#issuecomment-290755379 https://api.github.com/repos/pydata/xarray/issues/1342 MDEyOklzc3VlQ29tbWVudDI5MDc1NTM3OQ== shoyer 1217238 2017-03-31T16:06:09Z 2017-03-31T16:06:09Z MEMBER

@pwolfram I just pushed a commit, please take a look.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensures drop=True case works with empty mask 218291642
290752232 https://github.com/pydata/xarray/pull/1342#issuecomment-290752232 https://api.github.com/repos/pydata/xarray/issues/1342 MDEyOklzc3VlQ29tbWVudDI5MDc1MjIzMg== shoyer 1217238 2017-03-31T15:55:08Z 2017-03-31T15:55:08Z MEMBER

Something more subtle is going on here.

I can only reproduce this on Python 2, not Python 3. The difference seems to be in what .get_index() returns for an dimension of length 0 without labels: ```

python 2.7

In [11]: mask[:0].get_index('nCells') Out[11]: Index([], dtype='object', name=u'nCells')

python 3.5

In [5]: mask[:0].get_index('nCells') Out[5]: RangeIndex(start=0, stop=0, step=1, name='nCells') ```

I'll investigate a little further and propose a fix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensures drop=True case works with empty mask 218291642
290600174 https://github.com/pydata/xarray/pull/1342#issuecomment-290600174 https://api.github.com/repos/pydata/xarray/issues/1342 MDEyOklzc3VlQ29tbWVudDI5MDYwMDE3NA== pwolfram 4295853 2017-03-31T02:40:02Z 2017-03-31T02:40:08Z CONTRIBUTOR

@shoyer the changes have been made and this should be ready to merge now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensures drop=True case works with empty mask 218291642
290566932 https://github.com/pydata/xarray/pull/1342#issuecomment-290566932 https://api.github.com/repos/pydata/xarray/issues/1342 MDEyOklzc3VlQ29tbWVudDI5MDU2NjkzMg== pwolfram 4295853 2017-03-30T22:48:33Z 2017-03-30T22:48:33Z CONTRIBUTOR

@shoyer, note that we probably need this fix to be included in the 0.9.2 release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensures drop=True case works with empty mask 218291642

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);