issue_comments

Table actions

5 rows where issue = 217584777 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • `cumsum` providing correct behavior for non-coordinate DataArrays? · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
468512628 https://github.com/pydata/xarray/issues/1335#issuecomment-468512628 https://api.github.com/repos/pydata/xarray/issues/1335 MDEyOklzc3VlQ29tbWVudDQ2ODUxMjYyOA== stale[bot] 26384082 2019-03-01T02:00:07Z 2019-03-01T02:00:07Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `cumsum` providing correct behavior for non-coordinate DataArrays? 217584777
290570531 https://github.com/pydata/xarray/issues/1335#issuecomment-290570531 https://api.github.com/repos/pydata/xarray/issues/1335 MDEyOklzc3VlQ29tbWVudDI5MDU3MDUzMQ== shoyer 1217238 2017-03-30T23:09:19Z 2017-03-30T23:09:19Z MEMBER

Someone also wanted a default dimension for diff: https://github.com/pydata/xarray/pull/1131

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `cumsum` providing correct behavior for non-coordinate DataArrays? 217584777
289853741 https://github.com/pydata/xarray/issues/1335#issuecomment-289853741 https://api.github.com/repos/pydata/xarray/issues/1335 MDEyOklzc3VlQ29tbWVudDI4OTg1Mzc0MQ== shoyer 1217238 2017-03-28T18:00:45Z 2017-03-28T18:00:45Z MEMBER

Yes, it would be reasonable to not require specifying the dimension for one-dimensional arguments.

I recall this coming up before for other methods, but can't remember the particulars now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `cumsum` providing correct behavior for non-coordinate DataArrays? 217584777
289832319 https://github.com/pydata/xarray/issues/1335#issuecomment-289832319 https://api.github.com/repos/pydata/xarray/issues/1335 MDEyOklzc3VlQ29tbWVudDI4OTgzMjMxOQ== pwolfram 4295853 2017-03-28T16:47:36Z 2017-03-28T16:47:36Z CONTRIBUTOR

Thanks @fmaussion, it just seems strange that if the data is one-dimensional we return an error. I would agree that we probably want an error for dimensionality larger than one. I think the thing to change here is to make da.cumsum() work for one-dimensional da. But, it may not be worth the effort to fix this issue relative to other issues. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `cumsum` providing correct behavior for non-coordinate DataArrays? 217584777
289806577 https://github.com/pydata/xarray/issues/1335#issuecomment-289806577 https://api.github.com/repos/pydata/xarray/issues/1335 MDEyOklzc3VlQ29tbWVudDI4OTgwNjU3Nw== fmaussion 10050469 2017-03-28T15:24:58Z 2017-03-28T15:24:58Z MEMBER

I'm not sure that whether coordinates should play a role here, but rather the dimensionality of the data (i.e. maybe xarray could infer that the data has one dimension and work on that axis?).

I personally find the numpy behavior with ndarrays (flattening the array before applying cumsum) quite dangerous, I would rather like it to raise an error...

python a = np.arange(12).reshape((4, 3)) np.cumsum(a) array([ 0, 1, 3, 6, 10, 15, 21, 28, 36, 45, 55, 66])

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `cumsum` providing correct behavior for non-coordinate DataArrays? 217584777

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);