issue_comments

Table actions

5 rows where issue = 216329175 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Truncate long lines in repr of Dataset.attrs · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
288898100 https://github.com/pydata/xarray/issues/1319#issuecomment-288898100 https://api.github.com/repos/pydata/xarray/issues/1319 MDEyOklzc3VlQ29tbWVudDI4ODg5ODEwMA== Zac-HD 12229877 2017-03-24T00:15:06Z 2017-03-24T00:15:06Z CONTRIBUTOR

Sure, I'd be happy to. The above example will look much nicer, especially in wrapping environments:

<xarray.Dataset> Dimensions: (time: 246, x: 4000, y: 4000) Coordinates: * y (y) float64 -3.9e+06 -3.9e+06 -3.9e+06 -3.9e+06 -3.9e+06 ... * x (x) float64 1.5e+06 1.5e+06 1.5e+06 1.5e+06 1.5e+06 1.5e+06 ... * time (time) datetime64[ns] 1999-07-16T23:49:39 1999-07-25T23:43:07 ... Data variables: crs int32 ... blue (time, y, x) float64 ... green (time, y, x) float64 ... red (time, y, x) float64 ... nir (time, y, x) float64 ... swir1 (time, y, x) float64 ... swir2 (time, y, x) float64 ... Attributes: date_created: 2017-03-07T11:57:26.511217 Conventions: CF-1.6, ACDD-1.3 history: 2017-03-07T11:57:26.511307+11:00 adh547 datacube... geospatial_bounds: POLYGON ((148.49626113888138 -34.828378308133452... geospatial_bounds_crs: EPSG:4326 geospatial_lat_min: -35.7203183267 geospatial_lat_max: -34.7089119078 geospatial_lat_units: degrees_north geospatial_lon_min: 148.496261139 geospatial_lon_max: 149.734176111 geospatial_lon_units: degrees_east comment: - Ground Control Points (GCP): new GCP chips ... product_suite: Surface Reflectance NBAR+T 25m publisher_email: earth.observation@ga.gov.au keywords_vocabulary: GCMD product_version: 2 cdm_data_type: Grid references: - Berk, A., Anderson, G.P., Acharya, P.K., Ho... platform: LANDSAT-7 keywords: AU/GA,NASA/GSFC/SED/ESD/LANDSAT,REFLECTANCE,ETM+... publisher_name: Section Leader, Operations Section, NEMO, Geosci... institution: Commonwealth of Australia (Geoscience Australia) acknowledgment: Landsat data is provided by the United States Ge... license: CC BY Attribution 4.0 International License title: Surface Reflectance NBAR+T 25 v2 summary: Surface Reflectance (SR) is a suite of Earth Obs... instrument: ETM source: LANDSAT 7 ETM+ surface observation publisher_url: http://www.ga.gov.au

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Truncate long lines in repr of Dataset.attrs 216329175
288830638 https://github.com/pydata/xarray/issues/1319#issuecomment-288830638 https://api.github.com/repos/pydata/xarray/issues/1319 MDEyOklzc3VlQ29tbWVudDI4ODgzMDYzOA== shoyer 1217238 2017-03-23T19:14:01Z 2017-03-23T19:14:01Z MEMBER

Sounds like there is support here.

@Zac-HD Any interest in putting together a pull request? See here for the existing logic: https://github.com/pydata/xarray/blob/b3fc6c4e4fafdf4f075b791594633970a787ad79/xarray/core/formatting.py#L255

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Truncate long lines in repr of Dataset.attrs 216329175
288829627 https://github.com/pydata/xarray/issues/1319#issuecomment-288829627 https://api.github.com/repos/pydata/xarray/issues/1319 MDEyOklzc3VlQ29tbWVudDI4ODgyOTYyNw== fmaussion 10050469 2017-03-23T19:10:18Z 2017-03-23T19:10:18Z MEMBER

I am in favor of truncating the attrs too. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Truncate long lines in repr of Dataset.attrs 216329175
288828445 https://github.com/pydata/xarray/issues/1319#issuecomment-288828445 https://api.github.com/repos/pydata/xarray/issues/1319 MDEyOklzc3VlQ29tbWVudDI4ODgyODQ0NQ== pwolfram 4295853 2017-03-23T19:06:06Z 2017-03-23T19:06:06Z CONTRIBUTOR

As long as we can explicitly obtain the attrs data if necessary truncating the data for the repr makes sense. Note that appending a set of characters like ... to the end of it would be useful to indicate that the string continues but is only partially displayed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Truncate long lines in repr of Dataset.attrs 216329175
288827576 https://github.com/pydata/xarray/issues/1319#issuecomment-288827576 https://api.github.com/repos/pydata/xarray/issues/1319 MDEyOklzc3VlQ29tbWVudDI4ODgyNzU3Ng== shoyer 1217238 2017-03-23T19:02:39Z 2017-03-23T19:02:39Z MEMBER

OK, I'm not opposed to this. Truncating at 500 characters was basically a minimal sanity check -- we could certainly go further than this.

Anyone else have opinions here about sane default behavior? I don't work with files with lots of long attributes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Truncate long lines in repr of Dataset.attrs 216329175

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);