issue_comments

Table actions

6 rows where issue = 212471682 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • BUG/TST: Retain encoding upon concatenation · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
326454180 https://github.com/pydata/xarray/pull/1299#issuecomment-326454180 https://api.github.com/repos/pydata/xarray/issues/1299 MDEyOklzc3VlQ29tbWVudDMyNjQ1NDE4MA== jhamman 2443309 2017-09-01T00:22:22Z 2017-09-01T00:22:22Z MEMBER

I have an updated version of this PR up at #1545.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG/TST: Retain encoding upon concatenation 212471682
315203022 https://github.com/pydata/xarray/pull/1299#issuecomment-315203022 https://api.github.com/repos/pydata/xarray/issues/1299 MDEyOklzc3VlQ29tbWVudDMxNTIwMzAyMg== gerritholl 500246 2017-07-13T21:09:10Z 2017-07-13T21:09:10Z CONTRIBUTOR

Sorry, I've been really busy, but I'll get around to it eventually!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG/TST: Retain encoding upon concatenation 212471682
315197001 https://github.com/pydata/xarray/pull/1299#issuecomment-315197001 https://api.github.com/repos/pydata/xarray/issues/1299 MDEyOklzc3VlQ29tbWVudDMxNTE5NzAwMQ== jhamman 2443309 2017-07-13T20:45:41Z 2017-07-13T20:45:41Z MEMBER

@gerritholl - do have questions about my last comment? This should be pretty easy to get wrapped up and merged. We also need a whatsnew entry.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG/TST: Retain encoding upon concatenation 212471682
284814579 https://github.com/pydata/xarray/pull/1299#issuecomment-284814579 https://api.github.com/repos/pydata/xarray/issues/1299 MDEyOklzc3VlQ29tbWVudDI4NDgxNDU3OQ== jhamman 2443309 2017-03-07T18:36:20Z 2017-03-07T18:36:20Z MEMBER

No, I mean that there is an encoding attribute on the Dataset in addition to the DataArray that should also be propagated. I think you'll need to basically repeat what you did in variable.py for the Dataset: https://github.com/pydata/xarray/blob/10fc0846b1ae86d729ffd855641f4510947085a9/xarray/core/combine.py#L223

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG/TST: Retain encoding upon concatenation 212471682
284787562 https://github.com/pydata/xarray/pull/1299#issuecomment-284787562 https://api.github.com/repos/pydata/xarray/issues/1299 MDEyOklzc3VlQ29tbWVudDI4NDc4NzU2Mg== gerritholl 500246 2017-03-07T17:02:23Z 2017-03-07T17:02:23Z CONTRIBUTOR

Concatenation of DataArray and Dataset use the same underlying code, do you mean specifically for the test?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG/TST: Retain encoding upon concatenation 212471682
284776248 https://github.com/pydata/xarray/pull/1299#issuecomment-284776248 https://api.github.com/repos/pydata/xarray/issues/1299 MDEyOklzc3VlQ29tbWVudDI4NDc3NjI0OA== jhamman 2443309 2017-03-07T16:36:04Z 2017-03-07T16:36:04Z MEMBER

This looks pretty good. We also should make sure that the Dataset.encoding attribute is passed on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG/TST: Retain encoding upon concatenation 212471682

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);