issue_comments

Table actions

where issue = 212177054 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

These facets timed out: author_association

user 1

  • shoyer · 2 ✖

issue 1

  • Encoding lost upon concatenation · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
285101536 https://github.com/pydata/xarray/issues/1297#issuecomment-285101536 https://api.github.com/repos/pydata/xarray/issues/1297 MDEyOklzc3VlQ29tbWVudDI4NTEwMTUzNg== shoyer 1217238 2017-03-08T17:03:31Z 2017-03-08T17:03:31Z MEMBER

Mine retains it always upon concatenation, but if you prefer we could add an argument keep_encoding in analogy with keep_attrs. In that case we'd want to add it wherever we have keep_attrs.

No, I'm happy with your fix here. I'd rather keep encoding as hidden away from the user facing API as possible, because it's only relevant to a fraction of users (those reading and writing netCDF files).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Encoding lost upon concatenation 212177054
284911249 https://github.com/pydata/xarray/issues/1297#issuecomment-284911249 https://api.github.com/repos/pydata/xarray/issues/1297 MDEyOklzc3VlQ29tbWVudDI4NDkxMTI0OQ== shoyer 1217238 2017-03-08T00:56:23Z 2017-03-08T00:56:23Z MEMBER

I guess I'm not opposed to this per se, but preserving encoding in operations is even harder than attrs because it's possible encoding to no longer be valid. So currently most xarray operation simply delete encoding. That said, I can see some reasons for keeping it when concatenating (e.g., because concat is a fundamental part of open_mfdataset).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Encoding lost upon concatenation 212177054

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);