home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

8 rows where issue = 211888882 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

  • rabernat 3
  • shoyer 3
  • fmaussion 2

issue 1

  • Terminology for the various coordinates · 8 ✖

author_association 1

  • MEMBER 8
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
284468168 https://github.com/pydata/xarray/issues/1295#issuecomment-284468168 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDQ2ODE2OA== shoyer 1217238 2017-03-06T17:25:59Z 2017-03-06T17:25:59Z MEMBER

I agree that "auxiliary coordinate" is a better name, but I think "non-dimension coordinate" is clearer for the rare cases where we want to refer to these coordinates, given that we don't have any name for these coordinates in the xarray data model itself.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882
284437032 https://github.com/pydata/xarray/issues/1295#issuecomment-284437032 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDQzNzAzMg== rabernat 1197350 2017-03-06T15:51:55Z 2017-03-06T15:51:55Z MEMBER

I personally like "auxiliary coordinate" for the second type. This makes it clear that the variable gives additional information that is not as fundamental as the "dimension coordinate".

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882
284345624 https://github.com/pydata/xarray/issues/1295#issuecomment-284345624 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDM0NTYyNA== fmaussion 10050469 2017-03-06T09:32:19Z 2017-03-06T09:32:19Z MEMBER

I'm fine with this too. In particular, I find "dimension coordinate" much more meaningful than just "coordinate variable".

Do I read this correctly that we agree on: - dimension coordinates - non-dimension coordinates ?

I'm also fine with "auxiliary coordinates" for the second type. Let me know which one we should pick, I'll update the PR accordingly.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882
284280733 https://github.com/pydata/xarray/issues/1295#issuecomment-284280733 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDI4MDczMw== rabernat 1197350 2017-03-06T01:20:08Z 2017-03-06T01:20:08Z MEMBER

I don't feel very strongly about this...just pointing out that CF conventions do define terminology relevant to this discussion.

I'm fine with departing from CF convention terminology where we think it is unnecessarily confusing. But we should try to explain how and why we depart in the docs. @shoyer's comment above would in fact be a useful addition to the docs.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882
284273455 https://github.com/pydata/xarray/issues/1295#issuecomment-284273455 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDI3MzQ1NQ== shoyer 1217238 2017-03-05T23:40:57Z 2017-03-05T23:40:57Z MEMBER

I think it's confusing to use "coordinate" to refer to only variables matching dimension names and that "auxiliary coordinates" are not a type of coordinate. It just doesn't make any sense in terms of the usual rules for categorizing things. This is especially problematic for software like xarray which people use without looking carefully at the docs, and for which many users aren't familiar with CF conventions.

So I feel pretty strongly that CF/NUG conventions get this one wrong, and for xarray we should say that anything in .coords is a coordinate variable, which we can further qualify in various ways.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882
284213319 https://github.com/pydata/xarray/issues/1295#issuecomment-284213319 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDIxMzMxOQ== fmaussion 10050469 2017-03-05T08:23:20Z 2017-03-05T08:23:20Z MEMBER

Thanks @rabernat , I think this makes sense. I like "dimension coordinate" better and less ambiguous than "coordinate variable", but staying in line with CF clearly is the best thing to do here.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882
284199623 https://github.com/pydata/xarray/issues/1295#issuecomment-284199623 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDE5OTYyMw== rabernat 1197350 2017-03-05T02:11:50Z 2017-03-05T02:12:03Z MEMBER

Wherever possible we should try to adhere to CF convention terminology.

Some relevant definitions are:

coordinate variable We use this term precisely as it is defined in section 2.3.1 of the NUG . It is a one-dimensional variable with the same name as its dimension [e.g., time(time) ], and it is defined as a numeric data type with values that are ordered monotonically. Missing values are not allowed in coordinate variables.

auxiliary coordinate variable Any netCDF variable that contains coordinate data, but is not a coordinate variable (in the sense of that term defined by the NUG and used by this standard - see below). Unlike coordinate variables, there is no relationship between the name of an auxiliary coordinate variable and the name(s) of its dimension(s).

multidimensional coordinate variable An auxiliary coordinate variable that is multidimensional.

Using these definitions, it seems that @shoyer's "dimension coordinate" == CF's "coordinate variable" and @shoyer's "non-dimension coordinate" == CF's "auxiliary coordinate variable"

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882
284198109 https://github.com/pydata/xarray/issues/1295#issuecomment-284198109 https://api.github.com/repos/pydata/xarray/issues/1295 MDEyOklzc3VlQ29tbWVudDI4NDE5ODEwOQ== shoyer 1217238 2017-03-05T01:32:51Z 2017-03-05T01:32:51Z MEMBER

Should we simply call the former dimension coordinates and the latter optional coordinates?

Yes, let's call them "dimension coordinates".

The later could be called "non-dimension coordinates", but even dimension coordinates are optional so we shouldn't call these "optional".

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Terminology for the various coordinates 211888882

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 13.385ms · About: xarray-datasette