issue_comments

Table actions

5 rows where issue = 208713614 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Restored dim order in DataArray.rolling().reduce() · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
282784548 https://github.com/pydata/xarray/pull/1277#issuecomment-282784548 https://api.github.com/repos/pydata/xarray/issues/1277 MDEyOklzc3VlQ29tbWVudDI4Mjc4NDU0OA== jhamman 2443309 2017-02-27T17:11:17Z 2017-02-27T17:11:17Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Restored dim order in DataArray.rolling().reduce()  208713614
282598164 https://github.com/pydata/xarray/pull/1277#issuecomment-282598164 https://api.github.com/repos/pydata/xarray/issues/1277 MDEyOklzc3VlQ29tbWVudDI4MjU5ODE2NA== fujiisoup 6815844 2017-02-26T23:31:50Z 2017-02-26T23:31:50Z MEMBER

Hi @jhamman . Thanks for the review. Done and test passes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Restored dim order in DataArray.rolling().reduce()  208713614
282432897 https://github.com/pydata/xarray/pull/1277#issuecomment-282432897 https://api.github.com/repos/pydata/xarray/issues/1277 MDEyOklzc3VlQ29tbWVudDI4MjQzMjg5Nw== jhamman 2443309 2017-02-24T23:24:26Z 2017-02-24T23:24:26Z MEMBER

@fujiisoup - this looks great. Can you pull in the latest master branch? The Appveyor test should pass after that and we can merge this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Restored dim order in DataArray.rolling().reduce()  208713614
280966812 https://github.com/pydata/xarray/pull/1277#issuecomment-280966812 https://api.github.com/repos/pydata/xarray/issues/1277 MDEyOklzc3VlQ29tbWVudDI4MDk2NjgxMg== fujiisoup 6815844 2017-02-20T01:22:46Z 2017-02-20T01:22:46Z MEMBER

Thanks for reviewing. I added a few lines to whats-new docs. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Restored dim order in DataArray.rolling().reduce()  208713614
280963210 https://github.com/pydata/xarray/pull/1277#issuecomment-280963210 https://api.github.com/repos/pydata/xarray/issues/1277 MDEyOklzc3VlQ29tbWVudDI4MDk2MzIxMA== shoyer 1217238 2017-02-20T00:37:17Z 2017-02-20T00:37:17Z MEMBER

Looks good to me! Can you please add a bug fix note to the what's new doc?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Restored dim order in DataArray.rolling().reduce()  208713614

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);