issue_comments

Table actions

6 rows where issue = 205455788 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 6 ✖

issue 1

  • Consistent naming for xarray's methods that apply functions · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1111431038 https://github.com/pydata/xarray/issues/1251#issuecomment-1111431038 https://api.github.com/repos/pydata/xarray/issues/1251 IC_kwDOAMm_X85CPxd- max-sixty 5635139 2022-04-27T20:06:24Z 2022-04-27T20:06:24Z MEMBER

FYI the apply / map change went in a couple of years ago.

We still don't have an apply_raw. I think it probably makes sense to consolidate this with https://github.com/pydata/xarray/issues/1618, so I'll close this, even though it has some good discussion.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consistent naming for xarray's methods that apply functions 205455788
550035303 https://github.com/pydata/xarray/issues/1251#issuecomment-550035303 https://api.github.com/repos/pydata/xarray/issues/1251 MDEyOklzc3VlQ29tbWVudDU1MDAzNTMwMw== max-sixty 5635139 2019-11-05T21:44:44Z 2019-11-05T21:44:44Z MEMBER

OK. Does that inform your view on map vs apply?

I more strongly think that apply is a confusing and non-standard term for "run this function on each item in this container", even if it's pandas' name.

I'm keener to offer map an as option that necessarily reusing apply.

What are your thoughts re: - Adding map as the documented approach for run-on-each on Dataset & GroupBy - Adding apply_raw (or similar) as a new function that runs functions on the 'raw' arrays - Keeping apply around for backward-compat, similar to the drop case

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consistent naming for xarray's methods that apply functions 205455788
547592571 https://github.com/pydata/xarray/issues/1251#issuecomment-547592571 https://api.github.com/repos/pydata/xarray/issues/1251 MDEyOklzc3VlQ29tbWVudDU0NzU5MjU3MQ== max-sixty 5635139 2019-10-29T19:32:14Z 2019-10-30T00:22:56Z MEMBER

I put the change for Dataset.apply -> Dataset.map in. Should we do the same for GroupBy?

I think those are probably the two easiest decisions to make (and hopefully will kick off moving this issue forwards)

Edit: the reason I hesitated for GroupBy is that it's not exactly the same: the object returned isn't the same (i.e. Dataset.map returns a Dataset, while GroupBy.map would return a Dataset)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consistent naming for xarray's methods that apply functions 205455788
455353612 https://github.com/pydata/xarray/issues/1251#issuecomment-455353612 https://api.github.com/repos/pydata/xarray/issues/1251 MDEyOklzc3VlQ29tbWVudDQ1NTM1MzYxMg== max-sixty 5635139 2019-01-17T22:21:06Z 2019-01-17T22:21:06Z MEMBER

I would like to rename rolling.reduce to rolling.apply to be consistent with pandas & groupby

+0.5 if map fails

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consistent naming for xarray's methods that apply functions 205455788
455349535 https://github.com/pydata/xarray/issues/1251#issuecomment-455349535 https://api.github.com/repos/pydata/xarray/issues/1251 MDEyOklzc3VlQ29tbWVudDQ1NTM0OTUzNQ== max-sixty 5635139 2019-01-17T22:06:05Z 2019-01-17T22:06:05Z MEMBER

One proposal: rename apply to map

Would we accept this? I'd be up for doing the PR to deprecate apply and introduce map. It makes a Dataset more consistent with a standard mapping interface. But it would be inconsistent with pandas and a rename of fairly widely used method

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consistent naming for xarray's methods that apply functions 205455788
277576392 https://github.com/pydata/xarray/issues/1251#issuecomment-277576392 https://api.github.com/repos/pydata/xarray/issues/1251 MDEyOklzc3VlQ29tbWVudDI3NzU3NjM5Mg== max-sixty 5635139 2017-02-06T03:01:06Z 2017-02-06T03:01:06Z MEMBER

Sounds good. It breaks the consistency with pandas' apply, but map is much more logical

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consistent naming for xarray's methods that apply functions 205455788

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);