issue_comments

Table actions

6 rows where issue = 205414496 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • confusing dataset creation process · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
456756488 https://github.com/pydata/xarray/issues/1249#issuecomment-456756488 https://api.github.com/repos/pydata/xarray/issues/1249 MDEyOklzc3VlQ29tbWVudDQ1Njc1NjQ4OA== stale[bot] 26384082 2019-01-23T10:48:56Z 2019-01-23T10:48:56Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   confusing dataset creation process 205414496
277969098 https://github.com/pydata/xarray/issues/1249#issuecomment-277969098 https://api.github.com/repos/pydata/xarray/issues/1249 MDEyOklzc3VlQ29tbWVudDI3Nzk2OTA5OA== vnoel 731499 2017-02-07T11:14:42Z 2017-02-07T11:14:42Z CONTRIBUTOR

ok, I see. In case there's a vote, I vote for raising an error in 1D too :-)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   confusing dataset creation process 205414496
277776040 https://github.com/pydata/xarray/issues/1249#issuecomment-277776040 https://api.github.com/repos/pydata/xarray/issues/1249 MDEyOklzc3VlQ29tbWVudDI3Nzc3NjA0MA== fmaussion 10050469 2017-02-06T18:52:31Z 2017-02-06T18:52:31Z MEMBER

Would it mean that creating a Dataset with 1D arrays with no named dimension would raise an error? That would be very impractical.

it's already the case with any array of more than 1 dim.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   confusing dataset creation process 205414496
277767832 https://github.com/pydata/xarray/issues/1249#issuecomment-277767832 https://api.github.com/repos/pydata/xarray/issues/1249 MDEyOklzc3VlQ29tbWVudDI3Nzc2NzgzMg== vnoel 731499 2017-02-06T18:22:08Z 2017-02-06T18:22:08Z CONTRIBUTOR

I don't understand the "raise an error" option. Would it mean that creating a Dataset with 1D arrays with no named dimension would raise an error? That would be very impractical. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   confusing dataset creation process 205414496
277759129 https://github.com/pydata/xarray/issues/1249#issuecomment-277759129 https://api.github.com/repos/pydata/xarray/issues/1249 MDEyOklzc3VlQ29tbWVudDI3Nzc1OTEyOQ== shoyer 1217238 2017-02-06T17:52:05Z 2017-02-06T17:52:05Z MEMBER

This was intentional, but is perhaps too magical/overloaded.

Here's the reasoning: 1. If dimension names are not provided for a 1D array, presume that it's sole dimension is the same as it's name. 2. Variables with the same name as a dimension must be coordinates in the xarray data model. Hence make these variables coordinates, even if they appears in the data_vars argument. (This is a bit of a hold from before there was a separate coords argument.)

Note that if you put an array with 2 or more dimensions directly into data_vars/coords you currently get ValueError.

Alternative behaviors that might make more sense: - Raise an error for this behavior, only allowing implicit dimension names when you put an array in coords. - Deprecate implicit dimension names for 1D arrays altogether. Later, switch to labeling arrays with automatic dimension names like the DataArray constructor.

I'm not a huge fan of this second option because if you don't get an error it would be easy to construct datasets with some variables having the wrong dimension names.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   confusing dataset creation process 205414496
277576684 https://github.com/pydata/xarray/issues/1249#issuecomment-277576684 https://api.github.com/repos/pydata/xarray/issues/1249 MDEyOklzc3VlQ29tbWVudDI3NzU3NjY4NA== max-sixty 5635139 2017-02-06T03:04:02Z 2017-02-06T03:04:02Z MEMBER

I agree that outcome isn't what I would have expected. If you put the input into a DataArray first, this performs as expected.

```python In [5]: lat = np.random.rand(50000) * 180 - 90 ...: lon = np.random.rand(50000) * 360 - 180 ...: d = xr.Dataset({'latitude':xr.DataArray(lat), 'longitude':lon}) ...: ...:

In [6]: d Out[6]: <xarray.Dataset> Dimensions: (dim_0: 50000, longitude: 50000) Coordinates: * longitude (longitude) float64 -80.73 -118.8 88.66 -132.1 -74.87 27.2 ... Dimensions without coordinates: dim_0 Data variables: latitude (dim_0) float64 47.59 26.57 30.56 -12.52 65.44 70.32 84.45 ... ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   confusing dataset creation process 205414496

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);