issue_comments

Table actions

5 rows where issue = 203630267 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • `where` grows new dimensions for unrelated variables · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
751222858 https://github.com/pydata/xarray/issues/1234#issuecomment-751222858 https://api.github.com/repos/pydata/xarray/issues/1234 MDEyOklzc3VlQ29tbWVudDc1MTIyMjg1OA== stale[bot] 26384082 2020-12-25T09:49:51Z 2020-12-25T09:49:51Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `where` grows new dimensions for unrelated variables 203630267
457209817 https://github.com/pydata/xarray/issues/1234#issuecomment-457209817 https://api.github.com/repos/pydata/xarray/issues/1234 MDEyOklzc3VlQ29tbWVudDQ1NzIwOTgxNw== max-sixty 5635139 2019-01-24T14:11:12Z 2019-01-24T15:38:36Z MEMBER

Alternatively, we might simply skip variables in Dataset.where if they don't have overlapping dimensions. The logic gets a good deal more complex, though. Currently where is a thin wrapper around np.where.

Would skipping variables without the dimension be preferable? Or do people expect the broadcast?

We recently had a discussion re skipping variables that don't have the dimension supplied using .reduce, although that was for a clearer example, where broadcasting would be less relevant - e.g. rolling along a dimension

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `where` grows new dimensions for unrelated variables 203630267
457121127 https://github.com/pydata/xarray/issues/1234#issuecomment-457121127 https://api.github.com/repos/pydata/xarray/issues/1234 MDEyOklzc3VlQ29tbWVudDQ1NzEyMTEyNw== gerritholl 500246 2019-01-24T09:08:42Z 2019-01-24T09:08:42Z CONTRIBUTOR

Maybe this just needs a note in the documentation then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `where` grows new dimensions for unrelated variables 203630267
457074615 https://github.com/pydata/xarray/issues/1234#issuecomment-457074615 https://api.github.com/repos/pydata/xarray/issues/1234 MDEyOklzc3VlQ29tbWVudDQ1NzA3NDYxNQ== stale[bot] 26384082 2019-01-24T05:45:51Z 2019-01-24T05:45:51Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `where` grows new dimensions for unrelated variables 203630267
275721597 https://github.com/pydata/xarray/issues/1234#issuecomment-275721597 https://api.github.com/repos/pydata/xarray/issues/1234 MDEyOklzc3VlQ29tbWVudDI3NTcyMTU5Nw== shoyer 1217238 2017-01-27T17:23:03Z 2017-01-27T17:23:03Z MEMBER

You're not the first person to be confused about this (see https://github.com/pydata/xarray/issues/1217). This is indeed working as expected, though maybe not in the most useful way.

where works by broadcasting its arguments, and when ds.c (along the a dimension) gets broadcasted with ds.y (along the b dimension), the result gets the union of both dimensions.

Alternatively, we might simply skip variables in Dataset.where if they don't have overlapping dimensions. The logic gets a good deal more complex, though. Currently where is a thin wrapper around np.where.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `where` grows new dimensions for unrelated variables 203630267

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);