issue_comments

Table actions

4 rows where issue = 201762650 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Testing functions should be moved to a separate `xarray.testing` module · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
273824469 https://github.com/pydata/xarray/issues/1218#issuecomment-273824469 https://api.github.com/repos/pydata/xarray/issues/1218 MDEyOklzc3VlQ29tbWVudDI3MzgyNDQ2OQ== shoyer 1217238 2017-01-19T16:28:55Z 2017-01-19T16:28:55Z MEMBER

I think we could put the testing functions in testing.py but the skipif functions in xr.tests.init.py, and then not require pytest?

Yes, agreed!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Testing functions should be moved to a separate `xarray.testing` module 201762650
273814235 https://github.com/pydata/xarray/issues/1218#issuecomment-273814235 https://api.github.com/repos/pydata/xarray/issues/1218 MDEyOklzc3VlQ29tbWVudDI3MzgxNDIzNQ== max-sixty 5635139 2017-01-19T15:55:38Z 2017-01-19T15:55:38Z MEMBER

@fmaussion I'm unfortunately v busy for a while, if you could take this one that would be awesome...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Testing functions should be moved to a separate `xarray.testing` module 201762650
273814067 https://github.com/pydata/xarray/issues/1218#issuecomment-273814067 https://api.github.com/repos/pydata/xarray/issues/1218 MDEyOklzc3VlQ29tbWVudDI3MzgxNDA2Nw== max-sixty 5635139 2017-01-19T15:55:05Z 2017-01-19T15:55:05Z MEMBER

+1 on tests over test.

However much I love pytest, minimizing dependencies is a good goal.

I think we could put the testing functions in testing.py but the skipif functions in xr.tests.__init__.py, and then not require pytest?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Testing functions should be moved to a separate `xarray.testing` module 201762650
273739666 https://github.com/pydata/xarray/issues/1218#issuecomment-273739666 https://api.github.com/repos/pydata/xarray/issues/1218 MDEyOklzc3VlQ29tbWVudDI3MzczOTY2Ng== fmaussion 10050469 2017-01-19T10:38:12Z 2017-01-19T10:38:12Z MEMBER

yes, correct. The easiest fix would be to install pytest on RTD (assuming that all users using the xarray testing functions also have pytest installed) but this is not ideal.

@MaximilianR let me know if you have time to do this, otherwise I'll have a look later this week

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Testing functions should be moved to a separate `xarray.testing` module 201762650

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);