issue_comments

Table actions

3 rows where issue = 200364693 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • fmaussion · 3 ✖

issue 1

  • pass projection argument to plt.subplot when faceting with cartopy transform · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
272413551 https://github.com/pydata/xarray/issues/1201#issuecomment-272413551 https://api.github.com/repos/pydata/xarray/issues/1201 MDEyOklzc3VlQ29tbWVudDI3MjQxMzU1MQ== fmaussion 10050469 2017-01-13T10:42:02Z 2017-01-13T10:42:02Z MEMBER

I don't understand what you mean by 'adding you own to the signature'. Adding my own what to what signature?

;-) I meant adding your own keyword argument to the function's signature

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pass projection argument to plt.subplot when faceting with cartopy transform 200364693
272398208 https://github.com/pydata/xarray/issues/1201#issuecomment-272398208 https://api.github.com/repos/pydata/xarray/issues/1201 MDEyOklzc3VlQ29tbWVudDI3MjM5ODIwOA== fmaussion 10050469 2017-01-13T09:26:05Z 2017-01-13T09:26:05Z MEMBER

However it looks like no xarray code contains the transform keyword. However I definitely can use it in calls to plot(). I don't understand what is going on. Can someone enlighten me?

Yes, this is what I meant with xarray not being directly "cartopy aware". The reason is that xarray intends to be a general library, and tries to avoid defining too many keyword arguments in order to avoid confusion. However, xarray passes along any kw argument you want to the underlying mpl plot function (https://github.com/pydata/xarray/blob/master/xarray/plot/plot.py#L379). You'll have to catch it first, either from the kwargs dict or by adding your own to the signature (the latter being recommended only if necessary, for the reason I mentioned above)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pass projection argument to plt.subplot when faceting with cartopy transform 200364693
272293971 https://github.com/pydata/xarray/issues/1201#issuecomment-272293971 https://api.github.com/repos/pydata/xarray/issues/1201 MDEyOklzc3VlQ29tbWVudDI3MjI5Mzk3MQ== fmaussion 10050469 2017-01-12T21:46:53Z 2017-01-12T21:46:53Z MEMBER

This seems totally reasonable to me, and would be nice because it would improve the consistency between facetted and non-facetted plotting.

I don't really understand what you mean here. Neither facetted nor non-facetted plots have any logic to greate geoaxes automatically.

Otherwise, yes, I think that any logic making working with cartopy a little easier would be a good addition. The logic creating the axes is located here

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pass projection argument to plt.subplot when faceting with cartopy transform 200364693

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);