issue_comments

Table actions

5 rows where issue = 197920258 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Should we deprecate the compat and encoding constructor arguments? · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
457222134 https://github.com/pydata/xarray/issues/1188#issuecomment-457222134 https://api.github.com/repos/pydata/xarray/issues/1188 MDEyOklzc3VlQ29tbWVudDQ1NzIyMjEzNA== shoyer 1217238 2019-01-24T14:46:02Z 2019-01-24T14:46:02Z MEMBER

We still have compat as an argument to Dataset.__ini__.

I think we should probably deprecate it. I've never used it, and if you really want that high a level of control you can easily substitute using merge() instead. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should we deprecate the compat and encoding constructor arguments? 197920258
457204218 https://github.com/pydata/xarray/issues/1188#issuecomment-457204218 https://api.github.com/repos/pydata/xarray/issues/1188 MDEyOklzc3VlQ29tbWVudDQ1NzIwNDIxOA== max-sixty 5635139 2019-01-24T13:54:14Z 2019-01-24T13:54:14Z MEMBER

Compat is removed; is there a basis for keeping encoding?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should we deprecate the compat and encoding constructor arguments? 197920258
457178945 https://github.com/pydata/xarray/issues/1188#issuecomment-457178945 https://api.github.com/repos/pydata/xarray/issues/1188 MDEyOklzc3VlQ29tbWVudDQ1NzE3ODk0NQ== stale[bot] 26384082 2019-01-24T12:25:41Z 2019-01-24T12:25:41Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should we deprecate the compat and encoding constructor arguments? 197920258
269556854 https://github.com/pydata/xarray/issues/1188#issuecomment-269556854 https://api.github.com/repos/pydata/xarray/issues/1188 MDEyOklzc3VlQ29tbWVudDI2OTU1Njg1NA== clarkfitzg 5356122 2016-12-28T23:16:33Z 2016-12-28T23:16:33Z MEMBER

I haven't used these arguments in the constructors. But I don't find them distracting either.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should we deprecate the compat and encoding constructor arguments? 197920258
269547539 https://github.com/pydata/xarray/issues/1188#issuecomment-269547539 https://api.github.com/repos/pydata/xarray/issues/1188 MDEyOklzc3VlQ29tbWVudDI2OTU0NzUzOQ== fmaussion 10050469 2016-12-28T21:57:43Z 2016-12-28T21:57:43Z MEMBER

I don't have an opinion on compat (seems somehow unrelated to netCDF and https://github.com/pydata/xarray/issues/1170?), but I am +1 on encode. I always use encode when writing a dataset to disk, not at construction.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should we deprecate the compat and encoding constructor arguments? 197920258

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);