issue_comments

Table actions

4 rows where issue = 197057007 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Fix inconsistent behaviour for xarray.DataArray.rename · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
269021321 https://github.com/pydata/xarray/pull/1178#issuecomment-269021321 https://api.github.com/repos/pydata/xarray/issues/1178 MDEyOklzc3VlQ29tbWVudDI2OTAyMTMyMQ== shoyer 1217238 2016-12-23T17:26:41Z 2016-12-23T17:26:41Z MEMBER

Thanks @magonser, we really appreciate PRs, especially from new contributors!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix inconsistent behaviour for xarray.DataArray.rename 197057007
268984595 https://github.com/pydata/xarray/pull/1178#issuecomment-268984595 https://api.github.com/repos/pydata/xarray/issues/1178 MDEyOklzc3VlQ29tbWVudDI2ODk4NDU5NQ== magonser 14014177 2016-12-23T12:42:58Z 2016-12-23T12:42:58Z CONTRIBUTOR

Alright, I've added attribution. Thanks by the way for being patient with me in this PR, as I am just getting started on open source contributions. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix inconsistent behaviour for xarray.DataArray.rename 197057007
268942655 https://github.com/pydata/xarray/pull/1178#issuecomment-268942655 https://api.github.com/repos/pydata/xarray/issues/1178 MDEyOklzc3VlQ29tbWVudDI2ODk0MjY1NQ== shoyer 1217238 2016-12-23T05:28:05Z 2016-12-23T05:28:05Z MEMBER

@fmaussion that was my mistake here -- I didn't give myself credit on a few of the "Breaking Changes" but we should fix that.

@magonser want to insert a line giving yourself credit for this change?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix inconsistent behaviour for xarray.DataArray.rename 197057007
268781667 https://github.com/pydata/xarray/pull/1178#issuecomment-268781667 https://api.github.com/repos/pydata/xarray/issues/1178 MDEyOklzc3VlQ29tbWVudDI2ODc4MTY2Nw== fmaussion 10050469 2016-12-22T11:31:57Z 2016-12-22T11:31:57Z MEMBER

Slightly OT, but it occurred to me that we took the habit not to add an attribution (e.g. "By bla") to the "Breaking changes" list. This is probably nicer for the people who are quickly reading through the changes, but not really consistent with the bugfixes or enhancements.

In that case, I think you could list your change in the "bugfix" list rather than "breaking changes"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix inconsistent behaviour for xarray.DataArray.rename 197057007

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);