issue_comments

Table actions

4 rows where issue = 196278181 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • shoyer · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
269551434 https://github.com/pydata/xarray/pull/1171#issuecomment-269551434 https://api.github.com/repos/pydata/xarray/issues/1171 MDEyOklzc3VlQ29tbWVudDI2OTU1MTQzNA== shoyer 1217238 2016-12-28T22:29:20Z 2016-12-28T22:29:20Z MEMBER

My feeling is that vmin and vmax should always be exactly at the specified locations, but the location of the ticks in between is a little more flexible. If both vmin/vmax are set, then using linspace seems obvious, and if neither are set, then perhaps we should differ to whatever matplotlib defaults to. If only one is set, the solution is less clear. Maybe one limit be chosen exactly and the other in a "nice" way?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests for upcoming matplotlib v2 196278181
269549955 https://github.com/pydata/xarray/pull/1171#issuecomment-269549955 https://api.github.com/repos/pydata/xarray/issues/1171 MDEyOklzc3VlQ29tbWVudDI2OTU0OTk1NQ== shoyer 1217238 2016-12-28T22:16:47Z 2016-12-28T22:16:47Z MEMBER

@fmaussion as you note, even if this is a matplotlib bug, it seems like this was not doing quite the desired thing in xarray even with matplotlib 1.5 -- we really should be using np.linspace for this, not MaxNLocator.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests for upcoming matplotlib v2 196278181
269548744 https://github.com/pydata/xarray/pull/1171#issuecomment-269548744 https://api.github.com/repos/pydata/xarray/issues/1171 MDEyOklzc3VlQ29tbWVudDI2OTU0ODc0NA== shoyer 1217238 2016-12-28T22:07:01Z 2016-12-28T22:07:01Z MEMBER

The Matplotlib 2.0 release notes mention that the algorithm for the number of ticks in MaxNLocator has been changed but this seems at odds with the documented behavior for specifying a minimum number of intervals.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests for upcoming matplotlib v2 196278181
269369833 https://github.com/pydata/xarray/pull/1171#issuecomment-269369833 https://api.github.com/repos/pydata/xarray/issues/1171 MDEyOklzc3VlQ29tbWVudDI2OTM2OTgzMw== shoyer 1217238 2016-12-27T19:15:47Z 2016-12-27T19:15:47Z MEMBER

@fmaussion I think this is a bug, either with xarray plotting or matplotlib 2. If you supply vmin and vmax explicitly, shouldn't those be the minimum and maximum tick labels?

Also, shouldn't you get the requested number of levels? In matplotlib 2.0, I see 9 levels, not 7.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests for upcoming matplotlib v2 196278181

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);