issue_comments

Table actions

6 rows where issue = 196186567 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Dataset.encoding and unlimited dimensions for to_netcdf · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
274723021 https://github.com/pydata/xarray/pull/1170#issuecomment-274723021 https://api.github.com/repos/pydata/xarray/issues/1170 MDEyOklzc3VlQ29tbWVudDI3NDcyMzAyMQ== jhamman 2443309 2017-01-24T06:43:33Z 2017-01-24T06:43:33Z MEMBER

In we go. Thanks @shoyer for putting up with my short attention span on this one.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.encoding and unlimited dimensions for to_netcdf 196186567
274280237 https://github.com/pydata/xarray/pull/1170#issuecomment-274280237 https://api.github.com/repos/pydata/xarray/issues/1170 MDEyOklzc3VlQ29tbWVudDI3NDI4MDIzNw== jhamman 2443309 2017-01-21T18:47:42Z 2017-01-21T18:47:42Z MEMBER

@shoyer - all comments addressed and tests are passing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.encoding and unlimited dimensions for to_netcdf 196186567
269559684 https://github.com/pydata/xarray/pull/1170#issuecomment-269559684 https://api.github.com/repos/pydata/xarray/issues/1170 MDEyOklzc3VlQ29tbWVudDI2OTU1OTY4NA== jhamman 2443309 2016-12-28T23:44:13Z 2016-12-28T23:44:13Z MEMBER

@shoyer - comments addressed and green.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.encoding and unlimited dimensions for to_netcdf 196186567
269368135 https://github.com/pydata/xarray/pull/1170#issuecomment-269368135 https://api.github.com/repos/pydata/xarray/issues/1170 MDEyOklzc3VlQ29tbWVudDI2OTM2ODEzNQ== jhamman 2443309 2016-12-27T19:03:13Z 2016-12-27T19:03:13Z MEMBER

this is ready for a full review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.encoding and unlimited dimensions for to_netcdf 196186567
268942362 https://github.com/pydata/xarray/pull/1170#issuecomment-268942362 https://api.github.com/repos/pydata/xarray/issues/1170 MDEyOklzc3VlQ29tbWVudDI2ODk0MjM2Mg== shoyer 1217238 2016-12-23T05:22:46Z 2016-12-23T05:22:46Z MEMBER

So that is definitely a bug with scipy not handling ... for assignment with unlimited dimensions. We could make that work by making a proxy object that implements __setitem__ for Ellipsis by using a slice object or assignValue for scalars, but it would be nice to fix it upstream in scipy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.encoding and unlimited dimensions for to_netcdf 196186567
268348439 https://github.com/pydata/xarray/pull/1170#issuecomment-268348439 https://api.github.com/repos/pydata/xarray/issues/1170 MDEyOklzc3VlQ29tbWVudDI2ODM0ODQzOQ== jhamman 2443309 2016-12-20T20:22:39Z 2016-12-20T20:22:39Z MEMBER

@shoyer - I'm making progress here, although I still need to cleanup/add tests. Do you have an idea what might be causing this test failure though? I'm sure it's something I broke but I'm having trouble connecting the dots...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.encoding and unlimited dimensions for to_netcdf 196186567

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);