issue_comments

Table actions

3 rows where issue = 195576963 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • User warning / more transparent _FillValue interface for .to_netcdf() · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
268943572 https://github.com/pydata/xarray/issues/1163#issuecomment-268943572 https://api.github.com/repos/pydata/xarray/issues/1163 MDEyOklzc3VlQ29tbWVudDI2ODk0MzU3Mg== shoyer 1217238 2016-12-23T05:44:00Z 2016-12-23T05:44:00Z MEMBER

Fixed by #1165

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   User warning / more transparent _FillValue interface for .to_netcdf() 195576963
267094196 https://github.com/pydata/xarray/issues/1163#issuecomment-267094196 https://api.github.com/repos/pydata/xarray/issues/1163 MDEyOklzc3VlQ29tbWVudDI2NzA5NDE5Ng== laliberte 3217406 2016-12-14T17:13:05Z 2016-12-14T17:13:05Z CONTRIBUTOR

I'm pretty sure that of over many versions of CDO NaNs are not properly handled. For example, all the setmiss* commands have a very hard time with NaN's.

I have been using the encoding option but I find it not very intuitive and kind of cumbersome when there are many variables.

I think you're right that actually putting _FillValue = NaN in the variable attribute might be enough to solve most issues with third parties. If it still does not work, then it would be reasonable to raise this issue with each one of the third parties.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   User warning / more transparent _FillValue interface for .to_netcdf() 195576963
267086215 https://github.com/pydata/xarray/issues/1163#issuecomment-267086215 https://api.github.com/repos/pydata/xarray/issues/1163 MDEyOklzc3VlQ29tbWVudDI2NzA4NjIxNQ== shoyer 1217238 2016-12-14T16:46:05Z 2016-12-14T16:46:05Z MEMBER

I'm a little surprised that CDO cannot handle a NaN _FillValue -- are you sure this is actually the case? If so, it might be worth raising the issue with the CDO developers.

But actually, xarray currently does not even set _FillValue by default, though you can do this yourself on a per-variable basis by setting encoding. I think it would be reasonable to default to a _FillValue of NaN for floating point dtypes if that would help third party tools, given that that is how xarray's data model works (any other default choice would run the risk of over-writing user data).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   User warning / more transparent _FillValue interface for .to_netcdf() 195576963

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);