issue_comments

Table actions

3 rows where issue = 193467825 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Add drop=True argument to isel, sel and squeeze · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
266042325 https://github.com/pydata/xarray/pull/1153#issuecomment-266042325 https://api.github.com/repos/pydata/xarray/issues/1153 MDEyOklzc3VlQ29tbWVudDI2NjA0MjMyNQ== shoyer 1217238 2016-12-09T15:33:34Z 2016-12-09T15:33:34Z MEMBER

I obviously have a vested interest in the drop=True capability because we have found great use for it via where.

Well, to be clear drop=True works pretty differently on these methods than in where, so this might be confusing.

For isel, sel and squeeze, it drops scalar coordinates variables that would arise from indexing, whereas for where it drops some coordinate values. That said, the drop method already handles both cases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True argument to isel, sel and squeeze 193467825
266036302 https://github.com/pydata/xarray/pull/1153#issuecomment-266036302 https://api.github.com/repos/pydata/xarray/issues/1153 MDEyOklzc3VlQ29tbWVudDI2NjAzNjMwMg== pwolfram 4295853 2016-12-09T15:09:52Z 2016-12-09T15:09:52Z CONTRIBUTOR

@shoyer, I think this is really great and appreciate you doing this awesome work. I obviously have a vested interest in the drop=True capability because we have found great use for it via where. My vote is go for it!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True argument to isel, sel and squeeze 193467825
265968349 https://github.com/pydata/xarray/pull/1153#issuecomment-265968349 https://api.github.com/repos/pydata/xarray/issues/1153 MDEyOklzc3VlQ29tbWVudDI2NTk2ODM0OQ== shoyer 1217238 2016-12-09T09:17:02Z 2016-12-09T09:17:02Z MEMBER

Going to merge this shortly unless anyone has objections

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True argument to isel, sel and squeeze 193467825

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);