issue_comments

Table actions

11 rows where issue = 192816291 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Expose options for axis sharing between subplots · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
265457836 https://github.com/pydata/xarray/pull/1148#issuecomment-265457836 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NTQ1NzgzNg== fmaussion 10050469 2016-12-07T14:16:51Z 2016-12-07T14:16:51Z MEMBER

Thanks @hoonhout !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
265422603 https://github.com/pydata/xarray/pull/1148#issuecomment-265422603 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NTQyMjYwMw== hoonhout 7442202 2016-12-07T11:21:27Z 2016-12-07T11:21:27Z CONTRIBUTOR

I think this request is now ready to be pulled, right? Otherwise I keep merging these what's new lines :-)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264471550 https://github.com/pydata/xarray/pull/1148#issuecomment-264471550 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQ3MTU1MA== ocefpaf 950575 2016-12-02T14:53:28Z 2016-12-06T00:51:39Z CONTRIBUTOR

Ignore what I said. looking closer it makes sense to set the default to True.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264485891 https://github.com/pydata/xarray/pull/1148#issuecomment-264485891 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQ4NTg5MQ== fmaussion 10050469 2016-12-02T15:49:52Z 2016-12-02T15:49:52Z MEMBER

Thanks @hoonhout ! We're still missing an entry on whats-new.rst ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264471623 https://github.com/pydata/xarray/pull/1148#issuecomment-264471623 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQ3MTYyMw== hoonhout 7442202 2016-12-02T14:53:43Z 2016-12-02T14:53:43Z CONTRIBUTOR

Sure, I'll make my example into a test.

BTW, I would recommend to keep the default True.

Seaborn's default is indeed shared axes. This makes sense as a FacetGrid is intended to visualize single-source data.

MPL's default is indeed not to share axes. This also makes sense as MPL doesn't have any constraints on the data source.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264463656 https://github.com/pydata/xarray/pull/1148#issuecomment-264463656 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQ2MzY1Ng== fmaussion 10050469 2016-12-02T14:18:42Z 2016-12-02T14:18:42Z MEMBER

This would likely brake existing code, so @shoyer has to decide upon this. The current defaults are probably inherited from seaborn

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264461797 https://github.com/pydata/xarray/pull/1148#issuecomment-264461797 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQ2MTc5Nw== ocefpaf 950575 2016-12-02T14:09:37Z 2016-12-02T14:09:37Z CONTRIBUTOR

Would it make sense to set the default to False? I believe false is used in mpl.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264457608 https://github.com/pydata/xarray/pull/1148#issuecomment-264457608 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQ1NzYwOA== fmaussion 10050469 2016-12-02T13:49:05Z 2016-12-02T13:49:05Z MEMBER

Great example, thanks!

Actually this would make a good test since failing to set the new kwargs to False would raise an error. Maybe you could add this simple test here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264455218 https://github.com/pydata/xarray/pull/1148#issuecomment-264455218 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQ1NTIxOA== hoonhout 7442202 2016-12-02T13:36:39Z 2016-12-02T13:40:14Z CONTRIBUTOR

Here is an example of a random polar plot that doesn't work without the suggested modification:

```python import xarray import numpy as np from collections import OrderedDict from datetime import datetime

define dimensions

dims = OrderedDict([ ('time', [datetime(2016,12,1,1,0,0), datetime(2016,12,1,1,20,0)]), ('location', np.arange(3)), ('frequency', np.linspace(.1, .5, 20)), ('direction', np.linspace(0., 2.*np.pi, 50)), ])

create random data

E = np.random.rand(*[len(x) for x in dims.itervalues()])

construct DataArray

darray = xarray.DataArray(E, dims=dims, coords=dims)

plot data

darray.plot.pcolormesh(col='time', row='location', subplot_kws=dict(projection='polar'), sharex=False, sharey=False) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264405582 https://github.com/pydata/xarray/pull/1148#issuecomment-264405582 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDQwNTU4Mg== fmaussion 10050469 2016-12-02T09:00:11Z 2016-12-02T09:00:11Z MEMBER

Yes, this looks quite straight forward! Tests would be good but I expect this to be difficult to do in the current testing framework, so no pressure on that.

What would be nice is to have an example of your usage of FacetGrid. You can either post it here or wait until I get to add https://github.com/pydata/xarray/issues/1061 to the docs!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291
264266498 https://github.com/pydata/xarray/pull/1148#issuecomment-264266498 https://api.github.com/repos/pydata/xarray/issues/1148 MDEyOklzc3VlQ29tbWVudDI2NDI2NjQ5OA== shoyer 1217238 2016-12-01T19:18:54Z 2016-12-01T19:18:54Z MEMBER

This seems pretty safe to me. I think this just needs a "what's new" entry, though tests are also always appreciated!

@fmaussion can you take a look?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose options for axis sharing between subplots 192816291

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);