issue_comments

Table actions

9 rows where issue = 192702101 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Rolling count · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
311131587 https://github.com/pydata/xarray/pull/1145#issuecomment-311131587 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDMxMTEzMTU4Nw== shoyer 1217238 2017-06-26T17:46:49Z 2017-06-26T17:46:49Z MEMBER

Fair enough. Let's just stick with this then.

On Mon, Jun 26, 2017 at 10:44 AM, Maximilian Roos notifications@github.com wrote:

@MaximilianR commented on this pull request.

In xarray/core/ops.py https://github.com/pydata/xarray/pull/1145#discussion_r124073411:

@@ -198,6 +198,24 @@ def func(self, args, *kwargs): return func

+def rolling_count(rolling):

The problem with applying a move_sum on the not_nulls is that there are no nulls left in not_nulls (they are False), and so min_count won't work correctly.

But It does feel like this is a bit awkward atm, very open to other suggestions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1145#discussion_r124073411, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1s1ajEKR8DO5LvbpnbJQY7i8lvvDks5sH-4NgaJpZM4LAx3i . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
310869759 https://github.com/pydata/xarray/pull/1145#issuecomment-310869759 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDMxMDg2OTc1OQ== max-sixty 5635139 2017-06-24T22:32:44Z 2017-06-24T22:32:44Z MEMBER

@jhamman @shoyer updated

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
284526967 https://github.com/pydata/xarray/pull/1145#issuecomment-284526967 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDI4NDUyNjk2Nw== max-sixty 5635139 2017-03-06T20:46:54Z 2017-03-06T20:46:54Z MEMBER

Yes will take a look, thanks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
284295982 https://github.com/pydata/xarray/pull/1145#issuecomment-284295982 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDI4NDI5NTk4Mg== shoyer 1217238 2017-03-06T03:43:58Z 2017-03-06T03:43:58Z MEMBER

The open/close seems to have retrigged Travis. Looks like there's one failure for test_rolling_count_correct.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
284132306 https://github.com/pydata/xarray/pull/1145#issuecomment-284132306 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDI4NDEzMjMwNg== jhamman 2443309 2017-03-04T06:39:55Z 2017-03-04T06:39:55Z MEMBER

@MaximilianR - No idea what is going on here. It seems like github has lost the Travis hook for this PR. Maybe try closing and reopening it? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
284094939 https://github.com/pydata/xarray/pull/1145#issuecomment-284094939 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDI4NDA5NDkzOQ== max-sixty 5635139 2017-03-03T23:03:34Z 2017-03-03T23:03:34Z MEMBER

I'm getting some errors running tests on master - is that well known? I can debug this end, but will avoid if others are owning

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
284093531 https://github.com/pydata/xarray/pull/1145#issuecomment-284093531 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDI4NDA5MzUzMQ== max-sixty 5635139 2017-03-03T22:56:18Z 2017-03-03T22:56:18Z MEMBER

Any ideas why we aren't running standard CI?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
269094398 https://github.com/pydata/xarray/pull/1145#issuecomment-269094398 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDI2OTA5NDM5OA== jhamman 2443309 2016-12-24T18:02:04Z 2016-12-24T18:02:04Z MEMBER

@MaximilianR - if you can resolve the conflicts on this branch, I'll give it a final review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101
264058594 https://github.com/pydata/xarray/pull/1145#issuecomment-264058594 https://api.github.com/repos/pydata/xarray/issues/1145 MDEyOklzc3VlQ29tbWVudDI2NDA1ODU5NA== max-sixty 5635139 2016-12-01T02:11:44Z 2016-12-01T02:11:44Z MEMBER

@jhamman updated

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling count 192702101

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);