issue_comments

Table actions

4 rows where issue = 189099082 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix #1116 (rename of coordinates) · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
260687326 https://github.com/pydata/xarray/pull/1119#issuecomment-260687326 https://api.github.com/repos/pydata/xarray/issues/1119 MDEyOklzc3VlQ29tbWVudDI2MDY4NzMyNg== shoyer 1217238 2016-11-15T16:18:04Z 2016-11-15T16:18:04Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #1116 (rename of coordinates) 189099082
260395105 https://github.com/pydata/xarray/pull/1119#issuecomment-260395105 https://api.github.com/repos/pydata/xarray/issues/1119 MDEyOklzc3VlQ29tbWVudDI2MDM5NTEwNQ== shoyer 1217238 2016-11-14T17:03:25Z 2016-11-14T17:03:25Z MEMBER

Could you please add a brief bug-fix note to what's new? Otherwise this looks good to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #1116 (rename of coordinates) 189099082
260394978 https://github.com/pydata/xarray/pull/1119#issuecomment-260394978 https://api.github.com/repos/pydata/xarray/issues/1119 MDEyOklzc3VlQ29tbWVudDI2MDM5NDk3OA== shoyer 1217238 2016-11-14T17:03:03Z 2016-11-14T17:03:03Z MEMBER

This fix handles the case ds['somecoord'].rename({'somecoord':'newcoord'}). It does not apply to ds['somecoord'].rename('newcoord')

Indeed, I'm a little conflicted here. But I think this distinction makes sense, because it's useful to be able to rename an array without renaming its coordinate, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #1116 (rename of coordinates) 189099082
260339257 https://github.com/pydata/xarray/pull/1119#issuecomment-260339257 https://api.github.com/repos/pydata/xarray/issues/1119 MDEyOklzc3VlQ29tbWVudDI2MDMzOTI1Nw== burnpanck 1310437 2016-11-14T13:52:16Z 2016-11-14T14:51:26Z CONTRIBUTOR

This fix handles the case ds['somecoord'].rename({'somecoord':'newcoord'}). It does not apply to ds['somecoord'].rename('newcoord'), since the documentation of DataArray,rename does not mention coordinates at all if a string is given as argument. Nevertheless, one could argue the the two should be equivalent, in which case the latter would have to be fixed as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #1116 (rename of coordinates) 189099082

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);