issue_comments

Table actions

6 rows where issue = 188125831 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Docs tweaks · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
259523304 https://github.com/pydata/xarray/pull/1098#issuecomment-259523304 https://api.github.com/repos/pydata/xarray/issues/1098 MDEyOklzc3VlQ29tbWVudDI1OTUyMzMwNA== fmaussion 10050469 2016-11-09T20:52:19Z 2016-11-09T20:52:19Z MEMBER

OK, so now cartopy is installed properly (the map example looks good: http://xarray.pydata.org/en/latest/plotting.html#maps), but the example still fails with a netcdf3 error: http://xarray.pydata.org/en/latest/examples/multidimensional-coords.html :-(

I guess that netCDF4 didn't install properly. Next thing I'll try is to unpin the package version

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Docs tweaks 188125831
259483375 https://github.com/pydata/xarray/pull/1098#issuecomment-259483375 https://api.github.com/repos/pydata/xarray/issues/1098 MDEyOklzc3VlQ29tbWVudDI1OTQ4MzM3NQ== shoyer 1217238 2016-11-09T18:11:17Z 2016-11-09T18:11:17Z MEMBER

Yes, please do add cartopy and netcdf4 to our docs builds. The lack of these packages is only a legacy of times before RTD added conda support.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Docs tweaks 188125831
259481757 https://github.com/pydata/xarray/pull/1098#issuecomment-259481757 https://api.github.com/repos/pydata/xarray/issues/1098 MDEyOklzc3VlQ29tbWVudDI1OTQ4MTc1Nw== fmaussion 10050469 2016-11-09T18:04:29Z 2016-11-09T18:07:04Z MEMBER

Aha ok. Based on this example I assumed that everything was available on RTD, but it's also static.

I've been using cartopy and netcdf4 successfully on salem's docs with conda-forge. here is my environment file. @shoyer you OK with adding some packages to the doc builds?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Docs tweaks 188125831
259482069 https://github.com/pydata/xarray/pull/1098#issuecomment-259482069 https://api.github.com/repos/pydata/xarray/issues/1098 MDEyOklzc3VlQ29tbWVudDI1OTQ4MjA2OQ== fmaussion 10050469 2016-11-09T18:05:53Z 2016-11-09T18:05:53Z MEMBER

Alternatively, one should revert this change. I have no strong opinion about this. Doc builds are better to detect bugs in the code, but they are also tedious to maintain...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Docs tweaks 188125831
259478707 https://github.com/pydata/xarray/pull/1098#issuecomment-259478707 https://api.github.com/repos/pydata/xarray/issues/1098 MDEyOklzc3VlQ29tbWVudDI1OTQ3ODcwNw== fmaussion 10050469 2016-11-09T17:51:52Z 2016-11-09T17:51:52Z MEMBER

As always: -> testing locally is not the way to go with docs. I'll have a look at what's going wrong in the build: http://xarray.pydata.org/en/latest/examples/multidimensional-coords.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Docs tweaks 188125831
259476850 https://github.com/pydata/xarray/pull/1098#issuecomment-259476850 https://api.github.com/repos/pydata/xarray/issues/1098 MDEyOklzc3VlQ29tbWVudDI1OTQ3Njg1MA== fmaussion 10050469 2016-11-09T17:44:17Z 2016-11-09T17:44:17Z MEMBER

Perfect! I removed the reference to salem from this PR, which is ready to merge/review 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Docs tweaks 188125831

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);