issue_comments

Table actions

5 rows where issue = 187208913 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • New infer_intervals keyword for pcolormesh · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
259832229 https://github.com/pydata/xarray/pull/1079#issuecomment-259832229 https://api.github.com/repos/pydata/xarray/issues/1079 MDEyOklzc3VlQ29tbWVudDI1OTgzMjIyOQ== shoyer 1217238 2016-11-10T22:54:15Z 2016-11-10T22:54:15Z MEMBER

Yes, thanks!

On Thu, Nov 10, 2016 at 2:43 PM, Fabien Maussion notifications@github.com wrote:

@fmaussion commented on this pull request.

In xarray/test/test_plot.py https://github.com/pydata/xarray/pull/1079:

@@ -1,3 +1,5 @@ +from future import division

Yes OK. shouldn't I do this in a separate PR? I'll do it tomorrow though, it's getting late in Innsbruck...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1079, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1vqdXfCSLnXeKwewm2EH6rqzvp1fks5q854MgaJpZM4Ko_0w .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New infer_intervals keyword for pcolormesh 187208913
259249543 https://github.com/pydata/xarray/pull/1079#issuecomment-259249543 https://api.github.com/repos/pydata/xarray/issues/1079 MDEyOklzc3VlQ29tbWVudDI1OTI0OTU0Mw== shoyer 1217238 2016-11-08T20:26:08Z 2016-11-08T20:26:08Z MEMBER

Right, we used a static ipynb -> rst converter

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New infer_intervals keyword for pcolormesh 187208913
259247304 https://github.com/pydata/xarray/pull/1079#issuecomment-259247304 https://api.github.com/repos/pydata/xarray/issues/1079 MDEyOklzc3VlQ29tbWVudDI1OTI0NzMwNA== shoyer 1217238 2016-11-08T20:16:58Z 2016-11-08T20:16:58Z MEMBER

Yes, could certainly run this at doc build time instead of using a notebook. The advantage of the notebook is that it's easier to edit/assemble, and also easier to download and adjust.

In an ideal world, I think we would check in a notebook with cleared output and then run it and convert to HTML at doc build time. Looks like that's exactly what nbsphinx does if anyone wants to take a go at setting that up. Could be a much nicer way to write the docs than RST.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New infer_intervals keyword for pcolormesh 187208913
258456887 https://github.com/pydata/xarray/pull/1079#issuecomment-258456887 https://api.github.com/repos/pydata/xarray/issues/1079 MDEyOklzc3VlQ29tbWVudDI1ODQ1Njg4Nw== shoyer 1217238 2016-11-04T15:08:34Z 2016-11-04T15:08:34Z MEMBER

We definitely ignore cell boundaries -- they don't (yet) have any place in the xarray data model.

It would be nice to have a built in "interval" data type, along with an IntervalIndex, that we could use for storing and doing lookups along interval axes. At one point I was working on this for pandas (see https://github.com/pandas-dev/pandas/issues/7640), but then abandoned my effort when it seemed like it would be too much work to get it finished.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New infer_intervals keyword for pcolormesh 187208913
258318659 https://github.com/pydata/xarray/pull/1079#issuecomment-258318659 https://api.github.com/repos/pydata/xarray/issues/1079 MDEyOklzc3VlQ29tbWVudDI1ODMxODY1OQ== shoyer 1217238 2016-11-04T01:01:23Z 2016-11-04T01:01:23Z MEMBER

I would call this just infer_intervals. breaks in the helper function name is referring to an implementation detail of how we store the intervals (by using breaks).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New infer_intervals keyword for pcolormesh 187208913

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);