issue_comments

Table actions

11 rows where issue = 186326698 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Feature/rasterio · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
303038405 https://github.com/pydata/xarray/pull/1070#issuecomment-303038405 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDMwMzAzODQwNQ== fmaussion 10050469 2017-05-22T08:47:40Z 2017-05-22T08:47:40Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
303033917 https://github.com/pydata/xarray/pull/1070#issuecomment-303033917 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDMwMzAzMzkxNw== gidden 1392657 2017-05-22T08:28:53Z 2017-05-22T08:28:53Z CONTRIBUTOR

@byersiiasa indeed I am, in fact I'm reviewing #1260 which overtook this one =)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
303025395 https://github.com/pydata/xarray/pull/1070#issuecomment-303025395 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDMwMzAyNTM5NQ== byersiiasa 17701232 2017-05-22T07:50:55Z 2017-05-22T07:50:55Z NONE

@gidden you might be interested in this

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
279016156 https://github.com/pydata/xarray/pull/1070#issuecomment-279016156 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI3OTAxNjE1Ng== NicWayand 1117224 2017-02-10T17:54:13Z 2017-02-10T17:54:13Z NONE

Hi @fmaussion, no objections here. I got it working just barely for my project, and won't have time in the near future to devote to wrap this up.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
278940568 https://github.com/pydata/xarray/pull/1070#issuecomment-278940568 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI3ODk0MDU2OA== fmaussion 10050469 2017-02-10T13:22:02Z 2017-02-10T13:22:02Z MEMBER

Hi, unless there are objections I'd like to try to finish this PR. I just forked @NicWayand 's branch and started to look at it, and I hope to get something done during next week or so...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
257402325 https://github.com/pydata/xarray/pull/1070#issuecomment-257402325 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI1NzQwMjMyNQ== shoyer 1217238 2016-10-31T19:55:54Z 2016-10-31T19:55:54Z MEMBER

I would start by adding -v to our invocation of py.test in .travis.yml: https://github.com/pydata/xarray/blob/a247d9314d6a8df34df887106e234bbffebe1e48/.travis.yml#L72

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
257401393 https://github.com/pydata/xarray/pull/1070#issuecomment-257401393 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI1NzQwMTM5Mw== NicWayand 1117224 2016-10-31T19:52:56Z 2016-10-31T19:52:56Z NONE

Any idea why Segmentation faults occur for 3.4 and 4.5?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
257386904 https://github.com/pydata/xarray/pull/1070#issuecomment-257386904 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI1NzM4NjkwNA== shoyer 1217238 2016-10-31T18:56:57Z 2016-10-31T18:56:57Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
257385375 https://github.com/pydata/xarray/pull/1070#issuecomment-257385375 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI1NzM4NTM3NQ== NicWayand 1117224 2016-10-31T18:51:46Z 2016-10-31T18:51:46Z NONE

Travis-ci fail is because it can't find rasterio, which comes through the conda-forge channel (https://github.com/conda-forge/rasterio-feedstock). I think it needs to be added as described here (http://conda.pydata.org/docs/travis.html#additional-steps). But I am new to Travis-ci, so don't want to mess up the current .travis.yml file. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
257373530 https://github.com/pydata/xarray/pull/1070#issuecomment-257373530 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI1NzM3MzUzMA== NicWayand 1117224 2016-10-31T18:10:52Z 2016-10-31T18:10:52Z NONE

Tested open_mfdataset() on 100+ geotiffs and lazyloading with rasterio does appear to be working.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698
257343184 https://github.com/pydata/xarray/pull/1070#issuecomment-257343184 https://api.github.com/repos/pydata/xarray/issues/1070 MDEyOklzc3VlQ29tbWVudDI1NzM0MzE4NA== fmaussion 10050469 2016-10-31T16:27:59Z 2016-10-31T16:29:10Z MEMBER

This is awesome!

For 2: I think you don't have much more to do than make __getitem__ use the indexer to read the data with a window (example here)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/rasterio 186326698

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);