issue_comments

Table actions

4 rows where issue = 183792892 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • catch numpy arrays in attrs before converting to dict · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
256120955 https://github.com/pydata/xarray/pull/1052#issuecomment-256120955 https://api.github.com/repos/pydata/xarray/issues/1052 MDEyOklzc3VlQ29tbWVudDI1NjEyMDk1NQ== shoyer 1217238 2016-10-25T18:19:50Z 2016-10-25T18:19:50Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   catch numpy arrays in attrs before converting to dict 183792892
255850262 https://github.com/pydata/xarray/pull/1052#issuecomment-255850262 https://api.github.com/repos/pydata/xarray/issues/1052 MDEyOklzc3VlQ29tbWVudDI1NTg1MDI2Mg== shoyer 1217238 2016-10-24T20:05:35Z 2016-10-24T20:05:35Z MEMBER

Let's add a test case including a numpy scalar in an attribute? Otherwise, looks good to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   catch numpy arrays in attrs before converting to dict 183792892
255566810 https://github.com/pydata/xarray/pull/1052#issuecomment-255566810 https://api.github.com/repos/pydata/xarray/issues/1052 MDEyOklzc3VlQ29tbWVudDI1NTU2NjgxMA== shoyer 1217238 2016-10-23T03:05:13Z 2016-10-23T03:05:13Z MEMBER

Something more descriptive would probably be a good idea. Maybe ensure_us_time_resolution and decode_numpy_dict_values?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   catch numpy arrays in attrs before converting to dict 183792892
254875759 https://github.com/pydata/xarray/pull/1052#issuecomment-254875759 https://api.github.com/repos/pydata/xarray/issues/1052 MDEyOklzc3VlQ29tbWVudDI1NDg3NTc1OQ== jsignell 4806877 2016-10-19T17:01:15Z 2016-10-19T17:01:37Z CONTRIBUTOR

Are the names time_check and np_check specific enough for core/utils.py?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   catch numpy arrays in attrs before converting to dict 183792892

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);