issue_comments

Table actions

7 rows where issue = 181340410 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • DataArray.diff dim argument should be optional as is in docstring · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
605468155 https://github.com/pydata/xarray/issues/1040#issuecomment-605468155 https://api.github.com/repos/pydata/xarray/issues/1040 MDEyOklzc3VlQ29tbWVudDYwNTQ2ODE1NQ== smartass101 941907 2020-03-28T16:12:38Z 2020-03-28T16:12:38Z NONE

These days I mostly use .differentiate('coord') anyways, so I'm also for updating the docstring.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.diff dim argument should be optional as is in docstring 181340410
605453933 https://github.com/pydata/xarray/issues/1040#issuecomment-605453933 https://api.github.com/repos/pydata/xarray/issues/1040 MDEyOklzc3VlQ29tbWVudDYwNTQ1MzkzMw== dcherian 2448579 2020-03-28T14:22:54Z 2020-03-28T14:22:54Z MEMBER

I agree. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.diff dim argument should be optional as is in docstring 181340410
605453650 https://github.com/pydata/xarray/issues/1040#issuecomment-605453650 https://api.github.com/repos/pydata/xarray/issues/1040 MDEyOklzc3VlQ29tbWVudDYwNTQ1MzY1MA== max-sixty 5635139 2020-03-28T14:20:49Z 2020-03-28T14:20:49Z MEMBER

I'm low confidence keener on a consistent API that doesn't depend on the number of dimensions, rather than saving a kwarg, so would vote +0.1 on retaining the implementation and changing the docstring, such that it's required to pass a dimension name even with one dimension.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.diff dim argument should be optional as is in docstring 181340410
605444025 https://github.com/pydata/xarray/issues/1040#issuecomment-605444025 https://api.github.com/repos/pydata/xarray/issues/1040 MDEyOklzc3VlQ29tbWVudDYwNTQ0NDAyNQ== keewis 14808389 2020-03-28T12:56:37Z 2020-03-28T12:56:37Z MEMBER

this is still relevant. Should we update the docstring or the implementation? If we choose the latter we might be able to pick the commit by @smartass101 (or he might open a PR for it if he's still around?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.diff dim argument should be optional as is in docstring 181340410
591784930 https://github.com/pydata/xarray/issues/1040#issuecomment-591784930 https://api.github.com/repos/pydata/xarray/issues/1040 MDEyOklzc3VlQ29tbWVudDU5MTc4NDkzMA== stale[bot] 26384082 2020-02-27T05:11:46Z 2020-02-27T05:11:46Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.diff dim argument should be optional as is in docstring 181340410
377026301 https://github.com/pydata/xarray/issues/1040#issuecomment-377026301 https://api.github.com/repos/pydata/xarray/issues/1040 MDEyOklzc3VlQ29tbWVudDM3NzAyNjMwMQ== dcherian 2448579 2018-03-28T20:32:28Z 2018-03-28T20:32:28Z MEMBER

@smartass101 I was about to open an issue for this. Looks like you have already solved it. Wanna open a PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.diff dim argument should be optional as is in docstring 181340410
251991154 https://github.com/pydata/xarray/issues/1040#issuecomment-251991154 https://api.github.com/repos/pydata/xarray/issues/1040 MDEyOklzc3VlQ29tbWVudDI1MTk5MTE1NA== shoyer 1217238 2016-10-06T15:06:25Z 2016-10-06T15:06:25Z MEMBER

Seems reasonable to me. Want to put together a PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.diff dim argument should be optional as is in docstring 181340410

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);