issue_comments

Table actions

4 rows where issue = 181017850 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • attrs empty for open_mfdataset vs population for open_dataset · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
459940239 https://github.com/pydata/xarray/issues/1037#issuecomment-459940239 https://api.github.com/repos/pydata/xarray/issues/1037 MDEyOklzc3VlQ29tbWVudDQ1OTk0MDIzOQ== jhamman 2443309 2019-02-02T06:30:20Z 2019-02-02T06:30:20Z MEMBER

This should have been closed by https://github.com/pydata/xarray/pull/1038.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs empty for open_mfdataset vs population for open_dataset 181017850
457808121 https://github.com/pydata/xarray/issues/1037#issuecomment-457808121 https://api.github.com/repos/pydata/xarray/issues/1037 MDEyOklzc3VlQ29tbWVudDQ1NzgwODEyMQ== stale[bot] 26384082 2019-01-26T06:52:56Z 2019-01-26T06:52:56Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs empty for open_mfdataset vs population for open_dataset 181017850
251546401 https://github.com/pydata/xarray/issues/1037#issuecomment-251546401 https://api.github.com/repos/pydata/xarray/issues/1037 MDEyOklzc3VlQ29tbWVudDI1MTU0NjQwMQ== pwolfram 4295853 2016-10-04T23:52:26Z 2016-10-04T23:52:26Z CONTRIBUTOR

@shoyer, the issue is at merge of xarray/core/merge.py. Essentially the lines

python variables, coord_names, dims = merge_core(dict_like_objects, compat, join) merged = Dataset._construct_direct(variables, coord_names, dims)

drop the attributes. The solution is to do something like a merge of the attrs, e.g., a merge of the OrderedDicts. I've started a solution at #1038 if you want to take a preliminary look.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs empty for open_mfdataset vs population for open_dataset 181017850
251534952 https://github.com/pydata/xarray/issues/1037#issuecomment-251534952 https://api.github.com/repos/pydata/xarray/issues/1037 MDEyOklzc3VlQ29tbWVudDI1MTUzNDk1Mg== shoyer 1217238 2016-10-04T22:42:42Z 2016-10-04T22:42:42Z MEMBER

This was certainly not an intentional change, but on the other hand, the original behavior was not tested or intentionally specified, either.

It would be good to figure out where in open_mfdataset/auto_concat the attributes are lost.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs empty for open_mfdataset vs population for open_dataset 181017850

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);