issue_comments

Table actions

4 rows where issue = 178119989 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • .where() and .fillna() should preserve attributes · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
248683112 https://github.com/pydata/xarray/pull/1011#issuecomment-248683112 https://api.github.com/repos/pydata/xarray/issues/1011 MDEyOklzc3VlQ29tbWVudDI0ODY4MzExMg== shoyer 1217238 2016-09-21T17:26:38Z 2016-09-21T17:26:38Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .where() and .fillna() should preserve attributes 178119989
248395708 https://github.com/pydata/xarray/pull/1011#issuecomment-248395708 https://api.github.com/repos/pydata/xarray/issues/1011 MDEyOklzc3VlQ29tbWVudDI0ODM5NTcwOA== fmaussion 10050469 2016-09-20T18:47:43Z 2016-09-20T18:47:43Z MEMBER

OK. Sorry for the mess with Travis, I had a lot of typos :( It's getting late here and the new review system is a bit confusing

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .where() and .fillna() should preserve attributes 178119989
248392761 https://github.com/pydata/xarray/pull/1011#issuecomment-248392761 https://api.github.com/repos/pydata/xarray/issues/1011 MDEyOklzc3VlQ29tbWVudDI0ODM5Mjc2MQ== shoyer 1217238 2016-09-20T18:39:04Z 2016-09-20T18:39:04Z MEMBER

probably can put this in _fillna instead. Do you mean this should/could be done in _binary_op instead?

I forgot that we hack this into _binary_op right now. So no, please ignore this guidance then. This will cleaner after #964.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .where() and .fillna() should preserve attributes 178119989
248386044 https://github.com/pydata/xarray/pull/1011#issuecomment-248386044 https://api.github.com/repos/pydata/xarray/issues/1011 MDEyOklzc3VlQ29tbWVudDI0ODM4NjA0NA== fmaussion 10050469 2016-09-20T18:15:49Z 2016-09-20T18:15:49Z MEMBER

I implemented your comments with the exception of:

probably can put this in _fillna instead.

Do you mean this should/could be done in _binary_op instead?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .where() and .fillna() should preserve attributes 178119989

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);