issue_comments

Table actions

4 rows where issue = 177903376 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Shouldn't .where() pass the attributes of DataArrays and DataSets? · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
248143646 https://github.com/pydata/xarray/issues/1009#issuecomment-248143646 https://api.github.com/repos/pydata/xarray/issues/1009 MDEyOklzc3VlQ29tbWVudDI0ODE0MzY0Ng== fmaussion 10050469 2016-09-19T22:12:36Z 2016-09-19T22:12:36Z MEMBER

OK, that makes sense. It gives me some trouble with the geoloc accessor I am working on, but that's another story.

I'll try to put a PR together soon. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shouldn't .where() pass the attributes of DataArrays and DataSets?  177903376
248143020 https://github.com/pydata/xarray/issues/1009#issuecomment-248143020 https://api.github.com/repos/pydata/xarray/issues/1009 MDEyOklzc3VlQ29tbWVudDI0ODE0MzAyMA== shoyer 1217238 2016-09-19T22:10:02Z 2016-09-19T22:10:02Z MEMBER

I think we can keep attributes always for this operations.

The line I tried to draw was: - For operations that rearrange/manipulate existing data, keep attributes - For operations that do computation to produce new data, drop attributes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shouldn't .where() pass the attributes of DataArrays and DataSets?  177903376
248142213 https://github.com/pydata/xarray/issues/1009#issuecomment-248142213 https://api.github.com/repos/pydata/xarray/issues/1009 MDEyOklzc3VlQ29tbWVudDI0ODE0MjIxMw== fmaussion 10050469 2016-09-19T22:06:34Z 2016-09-19T22:06:34Z MEMBER

With a keep_attrs keyword, like .mean(), or always?

Since we are at it: what was the rationale behind not keeping the attributes per default everywhere? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shouldn't .where() pass the attributes of DataArrays and DataSets?  177903376
248140539 https://github.com/pydata/xarray/issues/1009#issuecomment-248140539 https://api.github.com/repos/pydata/xarray/issues/1009 MDEyOklzc3VlQ29tbWVudDI0ODE0MDUzOQ== shoyer 1217238 2016-09-19T21:59:29Z 2016-09-19T21:59:29Z MEMBER

Yes, I agree. .fillna() should also preserve attributes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shouldn't .where() pass the attributes of DataArrays and DataSets?  177903376

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);