issue_comments

Table actions

3 rows where issue = 174404136 and user = 8982598 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jcmgray · 3 ✖

issue 1

  • add 'no_conflicts' as compat option for merging non-conflicting data · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
246999780 https://github.com/pydata/xarray/pull/996#issuecomment-246999780 https://api.github.com/repos/pydata/xarray/issues/996 MDEyOklzc3VlQ29tbWVudDI0Njk5OTc4MA== jcmgray 8982598 2016-09-14T12:39:41Z 2016-09-14T12:39:41Z CONTRIBUTOR

OK, I have stripped the Dataset/Array methods which I agree were largely redundant. Since this sets this type of comparison/merge slightly apart, 'no_conflicts' seems the more intuitive wording when used only as a compat option so I've changed it to that.

And I've done a first pass at updating the docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add 'no_conflicts' as compat option for merging non-conflicting data 174404136
244612732 https://github.com/pydata/xarray/pull/996#issuecomment-244612732 https://api.github.com/repos/pydata/xarray/issues/996 MDEyOklzc3VlQ29tbWVudDI0NDYxMjczMg== jcmgray 8982598 2016-09-04T16:23:21Z 2016-09-04T16:23:21Z CONTRIBUTOR

One potential concern here is that performance is not going to be so great if you attempt to combine a bunch of variables with lazy data loaded with dask, because each comparison will trigger a separate computation. To that end, it would be nice to do the safety check in a single dask operation.

I will have a look into how to do this, but am not that familiar with dask. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add 'no_conflicts' as compat option for merging non-conflicting data 174404136
244612031 https://github.com/pydata/xarray/pull/996#issuecomment-244612031 https://api.github.com/repos/pydata/xarray/issues/996 MDEyOklzc3VlQ29tbWVudDI0NDYxMjAzMQ== jcmgray 8982598 2016-09-04T16:11:10Z 2016-09-04T16:11:10Z CONTRIBUTOR

Ah sorry - yes rebased locally then mistakenly merged the remote fork...

compat='no_conflicts' is possibly a better keyword argument.

Yes I thought that might be better also, the advantages of 'notnull_equals', (slightly more precise operational description and slightly better 'grammar' when using as a method: if ds1.notnull_equals(ds2): ... vs if ds1.no_conflicts(ds2): ...) are probably negligible since 'no_conflicts' is more intuitive for merge - and this is likely the main usage.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add 'no_conflicts' as compat option for merging non-conflicting data 174404136

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);