issue_comments

Table actions

4 rows where issue = 1738835134 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • `xarray.rolling_window` Converts `dims` Argument from Tuple to List Causing Issues for Cupy-Xarray · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1574365471 https://github.com/pydata/xarray/issues/7890#issuecomment-1574365471 https://api.github.com/repos/pydata/xarray/issues/7890 IC_kwDOAMm_X85d1ukf dcherian 2448579 2023-06-02T22:04:33Z 2023-06-02T22:04:33Z MEMBER

I think the only other one is dask, which should also work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `xarray.rolling_window` Converts `dims` Argument from Tuple to List Causing Issues for Cupy-Xarray 1738835134
1574338418 https://github.com/pydata/xarray/issues/7890#issuecomment-1574338418 https://api.github.com/repos/pydata/xarray/issues/7890 IC_kwDOAMm_X85d1n9y negin513 17344536 2023-06-02T21:30:05Z 2023-06-02T21:30:05Z CONTRIBUTOR

@dcherian : agreed! But I am afraid it might break other components. Although numpy seems to be able to handle both tuple and list in normalize_axis_tuple and I cannot see any other issues rising from this: https://github.com/numpy/numpy/blob/f67467c21a1797becde3097661996f60df4080ff/numpy/core/numeric.py#L1328

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `xarray.rolling_window` Converts `dims` Argument from Tuple to List Causing Issues for Cupy-Xarray 1738835134
1574331034 https://github.com/pydata/xarray/issues/7890#issuecomment-1574331034 https://api.github.com/repos/pydata/xarray/issues/7890 IC_kwDOAMm_X85d1mKa dcherian 2448579 2023-06-02T21:23:25Z 2023-06-02T21:27:06Z MEMBER

This seems like a real easy fix? axis = tuple(self.get_axis_num(d) for d in dim)

EDIT: the Array API seems to type axis as Optional[Union[int, Tuple[int, ...]]] pretty consistently, so it seems like we should always pass tuples down to the array library

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `xarray.rolling_window` Converts `dims` Argument from Tuple to List Causing Issues for Cupy-Xarray 1738835134
1574324606 https://github.com/pydata/xarray/issues/7890#issuecomment-1574324606 https://api.github.com/repos/pydata/xarray/issues/7890 IC_kwDOAMm_X85d1kl- welcome[bot] 30606887 2023-06-02T21:16:03Z 2023-06-02T21:16:03Z NONE

Thanks for opening your first issue here at xarray! Be sure to follow the issue template! If you have an idea for a solution, we would really welcome a Pull Request with proposed changes. See the Contributing Guide for more. It may take us a while to respond here, but we really value your contribution. Contributors like you help make xarray better. Thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `xarray.rolling_window` Converts `dims` Argument from Tuple to List Causing Issues for Cupy-Xarray 1738835134

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);