issue_comments

Table actions

3 rows where issue = 1700227455 and user = 6628425 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • spencerkclark · 3 ✖

issue 1

  • Preserve nanosecond resolution when encoding/decoding times · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1567109753 https://github.com/pydata/xarray/pull/7827#issuecomment-1567109753 https://api.github.com/repos/pydata/xarray/issues/7827 IC_kwDOAMm_X85daDJ5 spencerkclark 6628425 2023-05-29T13:00:30Z 2023-05-29T13:00:30Z MEMBER

One other tricky edge case that occurs to me is one where an extreme fill value (e.g. 1e30) is used for floating point fields. If we decode the times first, it might appear that the dates cannot be represented as nanosecond-precision values, but in reality they would be. We may need to think more about how to handle this edge case in addition to #7817.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve nanosecond resolution when encoding/decoding times 1700227455
1557089270 https://github.com/pydata/xarray/pull/7827#issuecomment-1557089270 https://api.github.com/repos/pydata/xarray/issues/7827 IC_kwDOAMm_X85cz0v2 spencerkclark 6628425 2023-05-22T11:58:18Z 2023-05-22T11:58:18Z MEMBER

Great, yeah, that's a nice example without writing to disk. Indeed I saw those warnings too, but omitted them in my earlier message to focus on the encoding issue (sorry about that). I agree that these are something we should address.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve nanosecond resolution when encoding/decoding times 1700227455
1539086265 https://github.com/pydata/xarray/pull/7827#issuecomment-1539086265 https://api.github.com/repos/pydata/xarray/issues/7827 IC_kwDOAMm_X85bvJe5 spencerkclark 6628425 2023-05-08T21:35:16Z 2023-05-08T21:35:16Z MEMBER

Thanks @kmuehlbauer -- I just wanted to give you a heads up that I'm pretty busy this week. Hopefully I'll get a free moment to look at this more closely next week.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve nanosecond resolution when encoding/decoding times 1700227455

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);