issue_comments

Table actions

3 rows where issue = 1696097756 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • nanosecond precision lost when reading time data · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1538354499 https://github.com/pydata/xarray/issues/7817#issuecomment-1538354499 https://api.github.com/repos/pydata/xarray/issues/7817 IC_kwDOAMm_X85bsW1D kmuehlbauer 5821660 2023-05-08T13:22:22Z 2023-05-08T13:22:52Z MEMBER

@dcherian Yes, I've setup a prototype in #7827. But the overall solution doesn't look that nice. The handling of fill_value has still to be done in CFMaskCoder.

Also #7098 is needed for this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nanosecond precision lost when reading time data 1696097756
1537031554 https://github.com/pydata/xarray/issues/7817#issuecomment-1537031554 https://api.github.com/repos/pydata/xarray/issues/7817 IC_kwDOAMm_X85bnT2C dcherian 2448579 2023-05-06T03:23:13Z 2023-05-06T03:23:13Z MEMBER

because CFMaskCoder will convert the variable to floating point and insert "NaN". In CFDatetimeCoder the floating point is cast back to int64 to transform into datetime64.

Can we reverse the order so that CFDatetimeCoder handles _FillValue for datetime arrays, and then it will be skipped in CFMaskCoder

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nanosecond precision lost when reading time data 1696097756
1534855008 https://github.com/pydata/xarray/issues/7817#issuecomment-1534855008 https://api.github.com/repos/pydata/xarray/issues/7817 IC_kwDOAMm_X85bfAdg kmuehlbauer 5821660 2023-05-04T14:11:26Z 2023-05-04T14:11:26Z MEMBER

cc @spencerkclark @DocOtak I've tried to at least find one example which incarnates as bug. Nevertheless the transformation from int to float in CFMaskCoder should be avoided.

We might think about special casing time data in CFMaskCoder, or handle masking of time data in CFDatetimeCoder/CFTimedeltaCoder.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nanosecond precision lost when reading time data 1696097756

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);